-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only switch to structure endpoint on viewport breakpoint if in edit mode #7920
Merged
fsbraun
merged 6 commits into
django-cms:develop-4
from
fsbraun:fix/structure-board-breakpoint
May 21, 2024
Merged
fix: Only switch to structure endpoint on viewport breakpoint if in edit mode #7920
fsbraun
merged 6 commits into
django-cms:develop-4
from
fsbraun:fix/structure-board-breakpoint
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jrief Can you give this a test run to verify this fixes your issue? |
…ngo-cms#6468)"" This reverts commit 71f0d7f.
vinitkumar
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get this merged and released 🚢 🚀
fsbraun
added a commit
that referenced
this pull request
May 22, 2024
4 tasks
4 tasks
fsbraun
added a commit
that referenced
this pull request
May 24, 2024
* fix: Only switch to structure endpoint on viewport breakpoint if in edit mode (#7920) * fix: #7859: allow special characters in page title (#7868) * fix #7859: allow special characters in page title * Update test_templatetags.py * Fix ruff issues in test_templatetags.py * One more time: fix ruff issues in test_templatetags.py --------- Co-authored-by: Fabian Braun <fsbraun@gmx.de> * Add fix of #7928 * Update cms.structureboard.js --------- Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
vinitkumar
pushed a commit
that referenced
this pull request
May 24, 2024
…nt) (#7928) * Revert "Removed default plugin creation for placeholders (#6468)" This reverts commit eef5cbb. * Fix: Only change structure board endpoint in edit mode * Fix typo * Revert "Revert "Removed default plugin creation for placeholders (#6468)"" This reverts commit 71f0d7f. * fix: Correct patch * Update cms.structureboard.js
fsbraun
added a commit
that referenced
this pull request
May 30, 2024
* fix: Only switch to structure endpoint on viewport breakpoint if in edit mode (#7920) * fix: #7859: allow special characters in page title (#7868) * fix #7859: allow special characters in page title * Update test_templatetags.py * Fix ruff issues in test_templatetags.py * One more time: fix ruff issues in test_templatetags.py --------- Co-authored-by: Fabian Braun <fsbraun@gmx.de> * docs: Improve explanation on how to use templates with django CMS (#7929) * docs: Improve docs on how to use templates * Fix typos, add `assertIn` to word list * Update setup.cfg * Remove "while" * Clarify use of CSS and JS libraries * Fix references. * Update djangocms-alias section * Update 04-templates.rst: Add missing space * fix codespell * fix codespell --------- Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7906 . Fixes #6566 .
Related resources
Checklist
develop-4