Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only switch to structure endpoint on viewport breakpoint if in edit mode #7920

Merged
merged 6 commits into from
May 21, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented May 14, 2024

Description

Fixes #7906 . Fixes #6566 .

  • Depending on viewport size the toolbar shows the structure or edit breakpoint. This is done to avoid ~2s latency when loading the edit endpoint on small devices. This must not happen at the preview endpoint.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented May 14, 2024

@jrief Can you give this a test run to verify this fixes your issue?

@fsbraun fsbraun added needs to be backported Commits need to be backported 4.1 labels May 14, 2024
@fsbraun fsbraun marked this pull request as ready for review May 14, 2024 21:21
@fsbraun fsbraun requested a review from jrief May 15, 2024 06:58
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@fsbraun fsbraun merged commit 9fbd71d into django-cms:develop-4 May 21, 2024
80 checks passed
@fsbraun fsbraun deleted the fix/structure-board-breakpoint branch May 22, 2024 08:03
@fsbraun fsbraun removed the needs to be backported Commits need to be backported label May 22, 2024
@fsbraun fsbraun mentioned this pull request May 22, 2024
4 tasks
@fsbraun fsbraun restored the fix/structure-board-breakpoint branch May 23, 2024 19:36
fsbraun added a commit that referenced this pull request May 24, 2024
* fix: Only switch to structure endpoint on viewport breakpoint if in edit mode (#7920)

* fix: #7859: allow special characters in page title (#7868)

* fix #7859: allow special characters in page title

* Update test_templatetags.py

* Fix ruff issues in test_templatetags.py

* One more time: fix ruff issues in test_templatetags.py

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Add fix of #7928

* Update cms.structureboard.js

---------

Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
vinitkumar pushed a commit that referenced this pull request May 24, 2024
…nt) (#7928)

* Revert "Removed default plugin creation for placeholders (#6468)"

This reverts commit eef5cbb.

* Fix: Only change structure board endpoint in edit mode

* Fix typo

* Revert "Revert "Removed default plugin creation for placeholders (#6468)""

This reverts commit 71f0d7f.

* fix: Correct patch

* Update cms.structureboard.js
fsbraun added a commit that referenced this pull request May 30, 2024
* fix: Only switch to structure endpoint on viewport breakpoint if in edit mode (#7920)

* fix: #7859: allow special characters in page title (#7868)

* fix #7859: allow special characters in page title

* Update test_templatetags.py

* Fix ruff issues in test_templatetags.py

* One more time: fix ruff issues in test_templatetags.py

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* docs: Improve explanation on how to use templates with django CMS (#7929)

* docs: Improve docs on how to use templates

* Fix typos, add `assertIn` to word list

* Update setup.cfg

* Remove "while"

* Clarify use of CSS and JS libraries

* Fix references.

* Update djangocms-alias section

* Update 04-templates.rst: Add missing space

* fix codespell

* fix codespell

---------

Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants