Discuss triangular meshes in step-1. #17001
Conversation
| for (const auto i : triangulation_quad.get_manifold_ids()) | ||
| if (i != numbers::flat_manifold_id) | ||
| triangulation.set_manifold(i, triangulation_quad.get_manifold(i)); |
There was a problem hiding this comment.
This is a bit unfortunate to have in the first tutorial. Isn't it possible to attache a spherical manifold?
There was a problem hiding this comment.
Yes, that's why a say the thing about "magic we're not yet ready to explain" above. I think attaching a manifold would not be clearer either, though. We only get to manifolds in step-9.
Do you remember why the function that subdivides cells into triangles doesn't do this itself? The documentation says you have to do it, so why not do it internally?
There was a problem hiding this comment.
Do you remember why the function that subdivides cells into triangles doesn't do this itself? The documentation says you have to do it, so why not do it internally?
Copying manifolds between triangulations is problematic, since might depend on the underlying triangulation. See TransfineManifold.
There was a problem hiding this comment.
Ah, good point. Yes, not much we can do about it.
My inclination is to leave the text as is, including stating that we're doing some magic, because it doesn't require substantial changes for people to play around with.
There was a problem hiding this comment.
Would it make sense to introduce a helper function in GridTools that we call here? It would reduce the amount of magic to a single function call.
|
On 5/20/24 01:37, Timo Heister wrote:
Would it make sense to introduce a helper function in GridTools that we call
here? It would reduce the amount of magic to a single function call.
I'm not opposed, but perhaps after this patch?
|
|
Anyone want to take a chance here? |
In reference to #16944.
Fixes #16944.