Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release GH action needs to be run twice #11134

Closed
jrbourbeau opened this issue May 20, 2024 · 1 comment · Fixed by #11138
Closed

Release GH action needs to be run twice #11134

jrbourbeau opened this issue May 20, 2024 · 1 comment · Fixed by #11138
Labels
needs triage Needs a response from a contributor

Comments

@jrbourbeau
Copy link
Member

We recently added some infrastructure to automatically create a release on GitHub when a release tag is pushed.

The 2024.5.0 release was the first time we were able to try this out. There was an issue where the release wasn't published properly (xref dask/community#379 (comment)) but manually rerunning the workflow fixed things. We released again last Friday and the same thing happened again. I reran the workflow and the release was properly rendered https://github.com/dask/dask/releases/tag/2024.5.1.

Opening an issue to figure out why the release jobs aren't working the first time and need to be rerun. cc @jacobtomlinson

Also, I noticed that in my GitHub feed there are two copies of the same content. Presumably related to rerunning the workflow (but that's just a guess).

Screenshot 2024-05-20 at 10 08 50 AM

@github-actions github-actions bot added the needs triage Needs a response from a contributor label May 20, 2024
@jacobtomlinson
Copy link
Member

jacobtomlinson commented May 21, 2024

My hypothesis is that in this project we push a release commit at the same time we push the tag, which I don't typically do in other places I've used this action setup. So the draft action and the publish action are triggered at the same time causing a race condition where the draft ends up winning. Then running the publish again manually corrects things.

If the release gets published, but then reverted to a draft again that might explain why you can see double in your feed as the original publish may be in a cache somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Needs a response from a contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants