New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Gitlab example integration #217
Comments
I see. Yeah I can test a change like this, not sure how suitable it would be to push this to everyone, but I don't think it should break anything for other people. I have limited experience with gitlab but I think better support for it would be beneficial. |
I would just extend the .gitlab-ci file for the new features. If you like, i can also pack this in extra files, which are then included (so the feature can be easily enabled / disabled) 😄 |
you can create a PR, sure |
i'm still experimenting with it. |
@kaystrobach - Hi, have you reached a solution for yourself yet? |
Is your feature request related to a problem? Please describe.
We want to review changes in gitlab with review apps
Describe the solution you'd like
use gitlab review app button inside the MR
Describe alternatives you've considered
there are none 😄
Additional context
I'm currently working on this.
The goal is to have an all in one workflow with preview from the build artifacts.
One thing, which breaks for me right now is the way how the index documents are linked:
they are linked like 'folder/' instead of 'folder/index.html' this breaks with gitlab view from artifacs, as this expects a complete link to a file
Are you interested in this?
The text was updated successfully, but these errors were encountered: