-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent results of Crystal::ASTNode::Call#id
#14500
Comments
The implementation should probably just delegate to I'm even wondering why we even have a separate |
|
Yeah right. Besides these exceptions? |
But those exceptions are precisely why |
I mean for every other type than |
There is also |
After #14490, I checked if any other
#to_macro_id
implementation is also problematic. This is the one forCall
:crystal/src/compiler/crystal/macros/methods.cr
Lines 2158 to 2164 in 562fb7b
It looks like the
@name
branch is forCall
nodes that have no arguments at all, but this misses a few cases:It also most certainly suffers from the same issue as #14489 (comment) regarding global
Call
s:The text was updated successfully, but these errors were encountered: