Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker deployment does not break if output plugin is broken #1972

Open
D1sD3s opened this issue Oct 19, 2023 · 1 comment
Open

Docker deployment does not break if output plugin is broken #1972

D1sD3s opened this issue Oct 19, 2023 · 1 comment

Comments

@D1sD3s
Copy link
Contributor

D1sD3s commented Oct 19, 2023

Describe the bug

The issue I'm encountering involves the Docker deployment. Specifically, when the output plugin experiences errors and fails to function as expected, the Docker deployment does not terminate. This occurs because exceptions are being caught and disregarded by the honeypot. In my perspective, it would be more desirable for the Docker deployment to exit when such issues with the plugin arise, as the plugin's proper operation is crucial.

To Reproduce

Steps to reproduce the behavior:

start the following docker-compose.yml with docker-compose up

--- 
version: '3' 
services: 
  cowrie: 
    image: cowrie/cowrie:3568988b 
    ports: 
      - "22:2222" 
    volumes: 
      - ./cowrie.cfg:/cowrie/cowrie-git/etc/cowrie.cfg 
    restart: always 

Use this section in cowrie.cfg to configure HPFeeds:

# HPFeeds3 
# Python3 implementation of HPFeeds 
[output_hpfeeds3] 
enabled = true 
server =_hpfeeds-broker_ 
port = 10000 
identifier = my_ident 
secret = my_secret 
debug = false 
channel = my_channel 

Expected behavior

In the event of a malfunctioning output plugin in the Docker deployment, the deployment should gracefully exit or stop. This would ensure that any issues with the plugin are addressed and don't compromise the overall functionality of the honeypot.

Additional context

Related issue, this approach would prevent overseeing problems like mentioned here: issue #1969

@D1sD3s
Copy link
Contributor Author

D1sD3s commented Oct 19, 2023

I added a PR i hope its okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant