{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":14483693,"defaultBranch":"main","name":"convert-units","ownerLogin":"convert-units","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-11-18T05:40:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/84060494?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717714248.0","currentOid":""},"activityList":{"items":[{"before":"f71d805a6d2633d3539adade1b7bdfb935638d1b","after":null,"ref":"refs/heads/performance","pushedAt":"2024-06-06T22:50:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"0d162653dc6166a216c4f8374269e7784f1a7940","after":"2ea6472ca72fbce1111919fa0c819e3e3eb3e0cd","ref":"refs/heads/main","pushedAt":"2024-06-06T22:50:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Small performance improvement (#325)\n\nUpdated the Converter class so that it accepts a unit cache. Then\r\nupdated the getUnit method to use the cache. This will make the `to` and\r\n`from` methods execute a bit faster.\r\n\r\nThis also fixes the index imports as not everything that should have\r\nbeen exported was being exported. Also fixed the default name not\r\nmatching the docs.","shortMessageHtmlLink":"Small performance improvement (#325)"}},{"before":null,"after":"f71d805a6d2633d3539adade1b7bdfb935638d1b","ref":"refs/heads/performance","pushedAt":"2024-06-06T22:48:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Small performance improvement\n\nUpdated the Converter class so that it accepts a unit cache. Then\nupdated the getUnit method to use the cache. This will make the `to` and\n`from` methods execute a bit faster.\n\nThis also fixes the index imports as not everything that should have\nbeen exported was being exported. Also fixed the default name not\nmatching the docs.","shortMessageHtmlLink":"Small performance improvement"}},{"before":"97f2a93ee15e2fb518d2183881e2cf850cc712ca","after":null,"ref":"refs/heads/update-eslint","pushedAt":"2024-06-06T22:22:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"1552fe33b3e6fc89a6467fdd965dfd7c8bce4b66","after":"0d162653dc6166a216c4f8374269e7784f1a7940","ref":"refs/heads/main","pushedAt":"2024-06-06T22:22:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update Eslint configuration (#324)\n\n* Update Eslint configuration\r\n\r\nMoved the configuration from the legacy format to the new format.\r\nUpdated related packages and installed types for some packages. Removed\r\nthe eslint-plugin-import package in favour of just relying on the\r\nprettier-plugin-organize-imports package to offer this feature. Changed\r\nthe source based on the new recommended rules.\r\n\r\n* Fixed linter error for a missing comma","shortMessageHtmlLink":"Update Eslint configuration (#324)"}},{"before":"6cc43d47d2b1fdae26aa2d8bba497d0184a625b9","after":"97f2a93ee15e2fb518d2183881e2cf850cc712ca","ref":"refs/heads/update-eslint","pushedAt":"2024-06-06T22:17:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Fixed linter error for a missing comma","shortMessageHtmlLink":"Fixed linter error for a missing comma"}},{"before":null,"after":"6cc43d47d2b1fdae26aa2d8bba497d0184a625b9","ref":"refs/heads/update-eslint","pushedAt":"2024-06-06T22:15:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update Eslint configuration\n\nMoved the configuration from the legacy format to the new format.\nUpdated related packages and installed types for some packages. Removed\nthe eslint-plugin-import package in favour of just relying on the\nprettier-plugin-organize-imports package to offer this feature. Changed\nthe source based on the new recommended rules.","shortMessageHtmlLink":"Update Eslint configuration"}},{"before":"7e9f089774fcd6f21cb1e8d01f7321796e4d5817","after":null,"ref":"refs/heads/update-ts","pushedAt":"2024-06-06T17:57:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"06758403b608463b59d244ae4a080a9e23919e7c","after":"1552fe33b3e6fc89a6467fdd965dfd7c8bce4b66","ref":"refs/heads/main","pushedAt":"2024-06-06T17:57:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update both Typescript to v5 and other packages (#323)","shortMessageHtmlLink":"Update both Typescript to v5 and other packages (#323)"}},{"before":null,"after":"7e9f089774fcd6f21cb1e8d01f7321796e4d5817","ref":"refs/heads/update-ts","pushedAt":"2024-06-06T17:44:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update both Typescript to v5 and other packages","shortMessageHtmlLink":"Update both Typescript to v5 and other packages"}},{"before":"c113cdbd39720eb90a76155d7cb1158b4ee1cf63","after":null,"ref":"refs/heads/fix-digital-units","pushedAt":"2024-06-06T14:43:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"1d599d2e07a3609892729652f2fa388dad02a4c0","after":"06758403b608463b59d244ae4a080a9e23919e7c","ref":"refs/heads/main","pushedAt":"2024-06-06T14:43:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update Digital Units (#316)\n\n* Update Digital Units\r\n\r\nThese changes should have happened a long time ago. Sorry that it took\r\nthis long to sort out.\r\n\r\nNote that these changes modify the unit names for the digital measure.\r\nTherefore, this is a breaking change if you are using the measure. The\r\nsystem names were also changed to be more clear and map to their\r\nrespective standards. The bit and byte units were moved to their own\r\nsystems to avoid duplication. I think it makes a lot more sense like\r\nthis and it also makes the conversions work correctly.\r\n\r\nThese changes will add the SI system and the IEC system. Again, byte\r\nand bit are their own systems.\r\n\r\n* Update digital units in README","shortMessageHtmlLink":"Update Digital Units (#316)"}},{"before":"c013ba329201ce30fa6e31f12f493131fba00972","after":"1d599d2e07a3609892729652f2fa388dad02a4c0","ref":"refs/heads/main","pushedAt":"2024-06-06T02:31:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Preserve unit type in `toBest` (#319)\n\n* Preserve unit type in `toBest`\n\nThe `BestResult` type now takes a type parameter `TUnits`, which\ndefaults to `string` for backward compatibility. That way, users who\nhave configured a measurement system with a custom unit type can\npreserve that unit type on `bestResult.unit`.\n\nThe code was already nicely set up for this, so no casts or refactors\nwere needed, just enriching the types themselves.\n\nTest Plan:\nType-level unit test added; running `npm test` passes with this change\nbut fails if you revert the change to `src/convert.ts` only. It also\nfails if you change `actual?.unit` to `'wat'`, with an appropriate error\nmessage, so it's testing the right thing and is not vacuous.\n\nwchargin-branch: tobest-preserve-unit-type\nwchargin-source: da4f1d80ceae079f445bd44f98a58e70ca91e9de\n\n* [tobest-preserve-unit-type: extract test to its own, explicit test case]\n\nwchargin-branch: tobest-preserve-unit-type\nwchargin-source: 226f128a465f5db191458e285b1242b6ecc613af\n\n* [tobest-preserve-unit-type: switch test to use `expect-type` library]\n\nwchargin-branch: tobest-preserve-unit-type\nwchargin-source: 8656aa65834add853c7a46c3c0f82542467187aa","shortMessageHtmlLink":"Preserve unit type in toBest (#319)"}},{"before":"9f3859a38c1473392fbe3ccca26cd12b98301bf2","after":"c013ba329201ce30fa6e31f12f493131fba00972","ref":"refs/heads/main","pushedAt":"2024-06-01T03:49:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Setting a more precise conversion from metric to imperial (#321)\n\n* Setting a more precise conversion from metric to imperial\n\nThe current conversion is missing two digest at the end. \r\nCurrently it is performing the following\r\nMath.round(4677.6713*(1/0.453592)) -> 10313\r\nbut the right would be \r\nMath.round(4677.6713*(1/0.45359237)) -> 10312\n\n* Fixing and adding test case","shortMessageHtmlLink":"Setting a more precise conversion from metric to imperial (#321)"}},{"before":"660cb867bf991fe800c1497b47e3f3801a512b1a","after":"c113cdbd39720eb90a76155d7cb1158b4ee1cf63","ref":"refs/heads/fix-digital-units","pushedAt":"2024-05-30T13:47:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update digital units in README","shortMessageHtmlLink":"Update digital units in README"}},{"before":null,"after":"660cb867bf991fe800c1497b47e3f3801a512b1a","ref":"refs/heads/fix-digital-units","pushedAt":"2024-05-28T19:57:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update Digital Units\n\nThese changes should have happened a long time ago. Sorry that it took\nthis long to sort out.\n\nNote that these changes modify the unit names for the digital measure.\nTherefore, this is a breaking change if you are using the measure. The\nsystem names were also changed to be more clear and map to their\nrespective standards. The bit and byte units were moved to their own\nsystems to avoid duplication. I think it makes a lot more sense like\nthis and it also makes the conversions work correctly.\n\nThese changes will add the SI system and the IEC system. Again, byte\nand bit are their own systems.","shortMessageHtmlLink":"Update Digital Units"}},{"before":"22a08a3c0676fcca4078e576f0ec7ff1ff1901d7","after":null,"ref":"refs/heads/update_to_best","pushedAt":"2024-05-14T19:08:27.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"96377dc5bb4b65fdddbc602b05db06039022f4a3","after":"9f3859a38c1473392fbe3ccca26cd12b98301bf2","ref":"refs/heads/main","pushedAt":"2024-05-14T19:08:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update `toBest` to return the original value (#313)\n\nThis will update the `toBest` to require the original value/unit if a\r\nbetter value is not found. The previous behaviour was to return `null`.\r\nThis will also be the case if the value is zero.\r\n\r\nThis will also add these cases to the documentation as well as add a\r\nnote stating that the *best* value is subjective and that `toBest` does\r\nnot work for all measures.\r\n\r\nTests were updated to reflect the changes and one test was removed\r\nbecause it was testing the same thing as another.","shortMessageHtmlLink":"Update toBest to return the original value (#313)"}},{"before":null,"after":"22a08a3c0676fcca4078e576f0ec7ff1ff1901d7","ref":"refs/heads/update_to_best","pushedAt":"2024-05-14T18:36:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Update `toBest` to return the original value\n\nThis will update the `toBest` to require the original value/unit if a\nbetter value is not found. The previous behaviour was to return `null`.\nThis will also be the case if the value is zero.\n\nThis will also add these cases to the documentation as well as add a\nnote stating that the *best* value is subjective and that `toBest` does\nnot work for all measures.\n\nTests were updated to reflect the changes and one test was removed\nbecause it was testing the same thing as another.","shortMessageHtmlLink":"Update toBest to return the original value"}},{"before":"26c76d9340090a3e09fb77f58c63c9bbc056b439","after":null,"ref":"refs/heads/allow_for_any_string","pushedAt":"2024-05-14T00:25:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"12cfbbf5cf1c1be9a17072158f7f871090a9c03d","after":"96377dc5bb4b65fdddbc602b05db06039022f4a3","ref":"refs/heads/main","pushedAt":"2024-05-14T00:25:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Fix unit type issues (#312)\n\n* Fix unit type issues\r\n\r\nThe main goal of these changes is to allow for any string to be passed\r\nto methods like `to` and `from` while still providing enough information\r\nthat the developer's editor will still provide a list of possible units.\r\n\r\nThe problem with the old implementation is that methods like `to` and\r\n`from` expect `TUnits`. Therefore, typescript expects the value being\r\npassed to be a member of that type. This isn't a big deal if the value\r\nis a string literal since typescript will infer the value's type to be\r\n`TUnits`. However, for cases where the value is dynamic, that value's\r\ntype has to be explicitly set to `TUnits` or a type guard needs to be\r\nused. Initially, I thought type guards were a good solution to this\r\nproblem but after some thought, I realised that the unit string would\r\nthen be checked twice. Once for the type guard and then by the method\r\nsince it needs to verify that the provided unit string exists. This is\r\nalso a pain to have to do all the time and adds a lot of boiler plate\r\ncode to any project using this lib. This commit removes the need to use\r\ntype guards by changing various method parameter types from `TUnit` to\r\n`TUnit | (string & {})`. The reason why this works and `TUnit | string`\r\ndoes not, is because the type definition for `TUnit | string` gets\r\nsimplified to just `string` since `TUnit` is within the `string` type.\r\nI'll admit, I don't exactly know why `TUnit | (string & {})` but\r\nwhat I do know is that it tricks typescript into not simplifying the\r\ntype which then allows for any member of `TUnit` or any `string`.\r\n\r\nWhy not just change everything to the type of `string`? Because I would\r\nstill like my editor to suggest the units as it helps prevent mistakes\r\nwhen using literal units. This is the whole reason why someone would\r\nwant to use typescript in the first place and configure their editor to\r\ngive them feedback based on the types.\r\n\r\nThis commit will fix #217 and a few others.\r\n\r\nHere are the other changes:\r\n\r\n- Updated jest config to ignore `TS151001`\r\n- Move jest config from javascript to typescript\r\n- Update jest and ts-jest versions to the latest\r\n- Remove `@ts-expect-error` flags from tests as they will not longer\r\n produce typescript errors\r\n- Add explicit error classes and JSDocs `@throws` for methods that can\r\n throw errors. The goal is to make it more obvious where and what\r\n errors can be thrown. Unfortunately, there isn't a way to do this with\r\n typescript.\r\n- The methods with updated argument types are: possibilities, list,\r\n describe, getUnit, toBest, to, and from","shortMessageHtmlLink":"Fix unit type issues (#312)"}},{"before":"3e7aac3ff4216405a5085873c7e5414ec1b7f1b3","after":"26c76d9340090a3e09fb77f58c63c9bbc056b439","ref":"refs/heads/allow_for_any_string","pushedAt":"2024-05-14T00:22:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Fix lint errors and types\n\nI thought `object` and `{}` were interchangeable but I was very wrong.\nThe `TUnits | (string & object)` type was originally `TUnits | (string &\n{})` but I changed it to avoid linting errors. For this trick to work,\nthe type needs to use `{}`. This will update the eslint configure to\nignore the use of `{}` and fixes the types.","shortMessageHtmlLink":"Fix lint errors and types"}},{"before":null,"after":"3e7aac3ff4216405a5085873c7e5414ec1b7f1b3","ref":"refs/heads/allow_for_any_string","pushedAt":"2024-05-14T00:08:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Fix unit type issues\n\nThe main goal of these changes is to allow for any string to be passed\nto methods like `to` and `from` while still providing enough information\nthat the developer's editor will still provide a list of possible units.\n\nThe problem with the old implementation is that methods like `to` and\n`from` expect `TUnits`. Therefore, typescript expects the value being\npassed to be a member of that type. This isn't a big deal if the value\nis a string literal since typescript will infer the value's type to be\n`TUnits`. However, for cases where the value is dynamic, that value's\ntype has to be explicitly set to `TUnits` or a type guard needs to be\nused. Initially, I thought type guards were a good solution to this\nproblem but after some thought, I realised that the unit string would\nthen be checked twice. Once for the type guard and then by the method\nsince it needs to verify that the provided unit string exists. This is\nalso a pain to have to do all the time and adds a lot of boiler plate\ncode to any project using this lib. This commit removes the need to use\ntype guards by changing various method parameter types from `TUnit` to\n`TUnit | (string & {})`. The reason why this works and `TUnit | string`\ndoes not, is because the type definition for `TUnit | string` gets\nsimplified to just `string` since `TUnit` is within the `string` type.\nI'll admit, I don't exactly know why `TUnit | (string & object)` but\nwhat I do know is that it tricks typescript into not simplifying the\ntype which then allows for any member of `TUnit` or any `string`.\n\nWhy not just change everything to the type of `string`? Because I would\nstill like my editor to suggest the units as it helps prevent mistakes\nwhen using literal units. This is the whole reason why someone would\nwant to use typescript in the first place and configure their editor to\ngive them feedback based on the types.\n\nThis commit will fix #217 and a few others.\n\nHere are the other changes:\n\n- Updated jest config to ignore `TS151001`\n- Move jest config from javascript to typescript\n- Update jest and ts-jest versions to the latest\n- Remove `@ts-expect-error` flags from tests as they will not longer\n produce typescript errors\n- Add explicit error classes and JSDocs `@throws` for methods that can\n throw errors. The goal is to make it more obvious where and what\n errors can be thrown. Unfortunately, there isn't a way to do this with\n typescript.\n- The methods with updated argument types are: possibilities, list,\n describe, getUnit, toBest, to, and from","shortMessageHtmlLink":"Fix unit type issues"}},{"before":"c3b258c9d2bd4620cb9ed4d397eea20d9cbaaa2c","after":"12cfbbf5cf1c1be9a17072158f7f871090a9c03d","ref":"refs/heads/main","pushedAt":"2024-05-13T22:08:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Features/add length dm (#309)\n\n* Add Decimeters as length unit\r\n\r\n* Remove endOfLine from .prettierrc.json","shortMessageHtmlLink":"Features/add length dm (#309)"}},{"before":"2a781b2910751d509e75ca28bd9f35ecbc678c2a","after":null,"ref":"refs/heads/package_fixes","pushedAt":"2024-03-07T20:23:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"}},{"before":"043cd2a5e5466c6ea459f49dec8fe0339c1175a9","after":"c3b258c9d2bd4620cb9ed4d397eea20d9cbaaa2c","ref":"refs/heads/main","pushedAt":"2024-03-07T20:23:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Rework package.json (#305)\n\n* Rework package.json\r\n\r\nThe issue #302 recommended a tool called publint, which showed various\r\nissues with the project's package.json. Since I'm no expert when it\r\ncomes to packaging, I think it would be very wise to follow the issue\r\nauthor's advice on fixing the publint errors/warnings and also running\r\npublint on PRs.\r\n\r\nI think going forward, code changes should not cause errors or warning\r\nwhen publint is ran. Aside from the fact that this will aid in testing\r\nand also serve as a sanity check so that releases don't break and cause\r\nfolks a ton of headaches.\r\n\r\nThis will also fix the node-ci action as it was trying to use node\r\nversions that haven't been released yet. I don't know why I added those\r\nand why I never tested it. :clown:\r\n\r\n* Remove Typecheck action\r\n\r\nThis action is not really required. The compile step will report any\r\nissues so a second check is not really helpful and just prolongs the CI\r\npipeline.","shortMessageHtmlLink":"Rework package.json (#305)"}},{"before":"8bf7fba5d726998baacf4cec0587a4cdb2793539","after":"2a781b2910751d509e75ca28bd9f35ecbc678c2a","ref":"refs/heads/package_fixes","pushedAt":"2024-03-07T20:18:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Remove Typecheck action\n\nThis action is not really required. The compile step will report any\nissues so a second check is not really helpful and just prolongs the CI\npipeline.","shortMessageHtmlLink":"Remove Typecheck action"}},{"before":null,"after":"8bf7fba5d726998baacf4cec0587a4cdb2793539","ref":"refs/heads/package_fixes","pushedAt":"2024-03-07T20:11:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"Rework package.json\n\nThe issue #302 recommended a tool called publint, which showed various\nissues with the project's package.json. Since I'm no expert when it\ncomes to packaging, I think it would be very wise to follow the issue\nauthor's advice on fixing the publint errors/warnings and also running\npublint on PRs.\n\nI think going forward, code changes should not cause errors or warning\nwhen publint is ran. Aside from the fact that this will aid in testing\nand also serve as a sanity check so that releases don't break and cause\nfolks a ton of headaches.\n\nThis will also fix the node-ci action as it was trying to use node\nversions that haven't been released yet. I don't know why I added those\nand why I never tested it. :clown:","shortMessageHtmlLink":"Rework package.json"}},{"before":"8fc2ac1a38645e700c4d0d781a467ec28ec22377","after":"043cd2a5e5466c6ea459f49dec8fe0339c1175a9","ref":"refs/heads/main","pushedAt":"2024-03-07T19:11:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"fix publint errors (#303)\n\n* changes to fix publint errors. Note many warnings still exist due to no cjs types files and cjs index being interpreted as ems\r\n\r\n* jest config as esm\r\n\r\n* rename eslint from .js to .cjs so not loaded as esm","shortMessageHtmlLink":"fix publint errors (#303)"}},{"before":"e5a4e4c95db82d2d94d1db345ca4099ff45b488f","after":"8fc2ac1a38645e700c4d0d781a467ec28ec22377","ref":"refs/heads/main","pushedAt":"2024-01-25T18:20:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Taar","name":"Randy Topliffe","path":"/Taar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/702909?s=80&v=4"},"commit":{"message":"3.0.0-beta.6","shortMessageHtmlLink":"3.0.0-beta.6"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXq4leQA","startCursor":null,"endCursor":null}},"title":"Activity ยท convert-units/convert-units"}