Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need test cases for v2 loopback options #10244

Open
mikebrow opened this issue May 20, 2024 · 2 comments
Open

Need test cases for v2 loopback options #10244

mikebrow opened this issue May 20, 2024 · 2 comments
Assignees

Comments

@mikebrow
Copy link
Member

What is the problem you're trying to solve

PR #10238 needs an integration test .. #10238 (review)

Describe the solution you'd like

Need a test bucket for the config switch use_internal_loopback, test should run with the flag enabled and disabled.. Either a command on running a container or an exec request that checks status and/or uses localhost.. confirms the result.

Additional context

CNI loopback plugin is typically not configured by default in the list of cni plugins to run.. However, kubernetes networking requires loopback (lo) be set to on for localhost in all containers of a pod. For example, to support port forwarding scenarios, a program in a container can listen to localhost:port. Additionally some kubernetes networking providers enable loopback as a matter of course even if not configured.

Thus, it is currently expected the CRI container runtimes will always enable loopback at a minimum for kubernetes pod network namespaces to which every kubernetes scheduled container is attached. CRI container runtimes have two ways to enable loopback, by inserting loopback into list of CNI plugins attached to the pod network namespace, or by directly setting loopback to up. The new switch picks which of those methods are used to enable loopback.

@cameronldroberts
Copy link

Hey! I'd like to pick this up.

@fuweid
Copy link
Member

fuweid commented May 27, 2024

Need a test bucket for the config switch use_internal_loopback, test should run with the flag enabled and disabled

I think we still need test case to check when containerd, which is running with use_internal_loopback=true, teardowns existing containers created by use_internal_loopback=false. As far as I know, the kernel will delete the loopback when net namespace is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants