Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500 bounty] Drive a loop in MetaDrive #30694

Closed
adeebshihadeh opened this issue Dec 12, 2023 · 2 comments · Fixed by #32308
Closed

[$500 bounty] Drive a loop in MetaDrive #30694

adeebshihadeh opened this issue Dec 12, 2023 · 2 comments · Fixed by #32308
Labels
bounty CI / testing good first issue Feasible for new contributers

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Dec 12, 2023 •
edited

Extend the MetaDrive test to drive a defined course and ensure it stays in the line. Requirements:

  • at least 1 minute of driving
  • passes reliably: 20+ times in a row
  • test fails if a reasonable user would have disengaged during the loop (drives out of lane, etc.)

Ideally, we can also configure the distance and/or runtime of the test with a simple parameter so that we can run a quick one in CI, and perhaps a longer version on master.

https://github.com/commaai/openpilot/blob/master/tools/sim/tests/test_sim_bridge.py
@adeebshihadeh adeebshihadeh pinned this issue Dec 12, 2023
@jnewb1
Copy link
Contributor

jnewb1 commented Dec 15, 2023

would also be cool if the route is logged as a github actions artifact that can be viewed in the openpilot tools if it fails

@adeebshihadeh
Copy link
Contributor Author

Good idea, added to the list

@jnewb1 jnewb1 linked a pull request Dec 20, 2023 that will close this issue
CI: MetaDrive in ga #30775
Closed
@jnewb1 jnewb1 removed a link to a pull request Dec 20, 2023
CI: MetaDrive in ga #30775
Closed
@bongbui321 bongbui321 mentioned this issue Jan 11, 2024
Closed
@mimi89999 mimi89999 mentioned this issue Mar 3, 2024
Merged
@bongbui321 bongbui321 mentioned this issue Apr 28, 2024
Merged
1 task
@adeebshihadeh adeebshihadeh unpinned this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty CI / testing good first issue Feasible for new contributers
Projects
openpilot bounties
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI/Simulator: Drive a loop in metadrive bongbui321/openpilot
2 participants
@adeebshihadeh @jnewb1