Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop jQuery, IE support #512

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Drop jQuery, IE support #512

merged 2 commits into from
Aug 9, 2022

Conversation

vsalvino
Copy link
Contributor

@vsalvino vsalvino commented Aug 9, 2022

  • Remove jQuery as base dependency from crx-front.js
  • Remove jQuery as dependency from crx-maps.js
  • Remove modernizr
  • Remove date/time picker fallbacks. Modern browsers as of the past year (2021) all provide widgets for date, time, datetime-local inputs.
  • Remove csrf token from ajax posts. Generally we should avoid front-end code/views which require CSRF tokens (except for actual forms) as they bust the cache.
  • Update fullcalendar to 5.11.2
  • Refactor map, event, and streamform code into separate scripts that live on their respective pages.
  • Format javascript code with prettier

This change drops IE support from the front-end. Most functionality will continue to work in a degraded state on the front-end in IE, but support is no longer guaranteed. Wagtail 3 and Bootstrap 5 have also dropped IE support.

Fixes #221 I think this also fixes #480 inadvertently as well.

@vsalvino vsalvino added this to the 1.0 milestone Aug 9, 2022
@vsalvino vsalvino merged commit 834a66f into dev Aug 9, 2022
@vsalvino vsalvino deleted the remove-jquery branch August 9, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Link Feature Logic incorrect Refactor jQuery
1 participant