Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm (modified) PSR2 coding standard #181

Open
samwilson opened this issue Sep 16, 2021 · 3 comments
Open

Confirm (modified) PSR2 coding standard #181

samwilson opened this issue Sep 16, 2021 · 3 comments

Comments

@samwilson
Copy link

Is there a phpcs ruleset that should be used for this repo? I'm working on adding footnotes and nearly have a patch ready.
@samdark
Copy link
Contributor

samdark commented Sep 18, 2021

@samwilson none that I'm aware of. @cebe?

@samwilson
Copy link
Author

I'll try to match whatever's existing, and go with PSR12 where it's not clear.

@samwilson
Copy link
Author

Oops, I only just noticed that it says in CONTRIBUTING.md:

I am following a code style that is basically PSR-2 but with TABS indentation (yes, I really do that ;) ). I am not going to nit-pick on all the details about the code style but indentation is a must. The important part is that code is readable. Methods should be documented using phpdoc style.

samwilson added a commit to samwilson/markdown that referenced this issue Sep 20, 2021
@samwilson
Add phpcs to CI, following PSR2
3539880 
Excludes any currently-failing sniffs, and fixes a few instances
of indenting being done with space rather than tab.

Refs cebe#181
@samwilson samwilson mentioned this issue Sep 20, 2021
Open
@samwilson samwilson changed the title Coding standard? Confirm (modified) PSR2 coding standard Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @samwilson