Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get recording and transcripts API endpoint #15131

Merged
merged 11 commits into from
May 22, 2024

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented May 20, 2024

What does this PR do?

TODO:

  • Add unit tests

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Copy link
Contributor

github-actions bot commented May 20, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 20, 2024
Copy link

linear bot commented May 20, 2024

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 10:39am
cal ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 10:39am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 10:39am

@Udit-takkar Udit-takkar changed the title feat: add get recording API endpoint feat: add get recording and transcripts API endpoint May 20, 2024
@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth High priority Created by Linear-GitHub Sync ✨ feature New feature or request labels May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Comment on lines +13 to +14
/**
* @swagger
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added swagger configuration

@Udit-takkar Udit-takkar marked this pull request as ready for review May 21, 2024 12:45
@graphite-app graphite-app bot requested a review from a team May 21, 2024 12:45
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label May 21, 2024
Copy link

graphite-app bot commented May 21, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

deploysentinel bot commented May 21, 2024

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/22/2024 10:51:13am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cb866ad

Started: 05/22/2024 10:47:53am UTC

⚠️ Flakes

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1Initial Attempt
3.36% (8) 8 / 238 runs
failed over last 7 days
11.34% (27) 27 / 238 runs
flaked over last 7 days

📄   apps/web/playwright/hash-my-url.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
hash my url generate url hash
Retry 2Retry 1Initial Attempt
7.24% (16) 16 / 221 runs
failed over last 7 days
28.05% (62) 62 / 221 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0.45% (1) 1 / 222 run
failed over last 7 days
11.26% (25) 25 / 222 runs
flaked over last 7 days
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.45% (1) 1 / 221 run
failed over last 7 days
31.22% (69) 69 / 221 runs
flaked over last 7 days

📄   apps/web/playwright/impersonation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 1Initial Attempt
2.21% (5) 5 / 226 runs
failed over last 7 days
15.04% (34) 34 / 226 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1Initial Attempt
0.45% (1) 1 / 223 run
failed over last 7 days
63.68% (142) 142 / 223 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1Initial Attempt
0% (0) 0 / 223 runs
failed over last 7 days
65.47% (146) 146 / 223 runs
flaked over last 7 days
Namespacing Different namespaces can have different init configs
Retry 1Initial Attempt
0% (0) 0 / 223 runs
failed over last 7 days
62.33% (139) 139 / 223 runs
flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1Initial Attempt
0% (0) 0 / 223 runs
failed over last 7 days
65.47% (146) 146 / 223 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can verify the newly added secondary email
Retry 1Initial Attempt
2.65% (7) 7 / 264 runs
failed over last 7 days
21.21% (56) 56 / 264 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode
Copy link
Contributor

@Udit-takkar None of the mandatory tasks are checked. Were you planning on doing them?

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean. I love it. Some basic unit tests would be nice tho. You can use the ones at apps/api/v1/test/lib/event-types/[id]/_get.test.ts as reference.

Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting unit tests

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the new tests from my perspective :)

@emrysal emrysal merged commit 6dd4933 into main May 22, 2024
43 checks passed
@emrysal emrysal deleted the feat/cal-video-endpoint branch May 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3762] Create an API endpoint for recording and transcripts
4 participants