Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin commits instead of branches #294

Open
1 task done
mattmassicotte opened this issue Apr 1, 2024 · 3 comments
Open
1 task done

Pin commits instead of branches #294

mattmassicotte opened this issue Apr 1, 2024 · 3 comments
Labels
Enhancement New feature or request

Comments

@mattmassicotte
Copy link
Contributor

Feature Suggestion

Mandatory Information

Description
It is convenient, but problematic, to pin SPM packages to branches. Branches changes, which mean that builds are not repeatable. Both DavidFoundation and LaunchAtLogin are currently pointing to main.

It's less-convene it, but far safer, to put specific commits in there. This way, you guarantee that you have controlled what going is going into what version, and that updates are intentional instead of a side-effect of building.

Type
Non-UI

Mockups

Optional Information

Additional Information

Checklist

  • I have filled out everything under Mandatory Information
@mattmassicotte mattmassicotte added the Enhancement New feature or request label Apr 1, 2024
@buresdv
Copy link
Owner

buresdv commented Apr 1, 2024

Oh, good eye! I never noticed they were pointing at a branch. Would it be okay to change them to "Up to Next Major Version", or do you think they should really be pointing to a specific commit?

@mattmassicotte
Copy link
Contributor Author

I think Up to Next Major Version is the right choice if there actually is a release that will work. But, if you need something on a branch that hasn't been released, a specific commit is safest.

@buresdv
Copy link
Owner

buresdv commented Apr 10, 2024

Thanks for the tip, I'll fix it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants