Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fees can be <1 sat/B but bigger than 0 sat/B #32

Open
karelbilek opened this issue Aug 30, 2018 · 3 comments
Open

fees can be <1 sat/B but bigger than 0 sat/B #32

karelbilek opened this issue Aug 30, 2018 · 3 comments

Comments

@karelbilek
Copy link
Contributor

I am not sure how well is the code handling fees smaller than 1sat/B

For example DASH regularly has those fees and there is no reason why bitcoin couldn't have that

(yes, I know code in this repo is old and I sort of gave up on helping you with it :( but I noticed this issue now )

@dcousens
Copy link
Contributor

@karel-3d did you have an example of what you mean?

@karelbilek
Copy link
Contributor Author

In all the fixtures, the feerate can be 0.1 (or 1.1 or 2.1 etc)

I am not sure if the library will handle it well. It probably will? It should be added to tests though, all feeRates are always numbers and bigger than 1

Here etc

https://github.com/bitcoinjs/coinselect/blob/master/test/fixtures/index.json#L4

@dcousens
Copy link
Contributor

Ok. Let's test decimal fee rates :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants