Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for --ignore-empty-password #188

Open
MithicSpirit opened this issue Nov 29, 2020 · 3 comments
Open

Option for --ignore-empty-password #188

MithicSpirit opened this issue Nov 29, 2020 · 3 comments

Comments

@MithicSpirit
Copy link

There should be a way to set the --ignore-empty-password i3lock flag, with a flag for betterlockscreen (e.g. betterlockscreen -s -e) and/or with an option in betterlockscreenrc (ignoreemptypassword=true).

@MithicSpirit
Copy link
Author

This is now possible (and has been for a few months) by using -- --ignore-empty-password, though it would be nice to be able to also set it in the config (maybe have an option in the config to set i3lock arguments like with --?)

@SebTM
Copy link
Collaborator

SebTM commented Sep 1, 2021

What do you think of a #245 related solution, where you could do this with creating a preLock-script and doing something like lockargs="$lockargs -e" there?

The reason why I hesitate with it, is that in the end, we will handle almost each possible i3lock-color argument...
Another alternative would be creating an alias/keybinding for it then the length of the command doesn't really matter?

@MithicSpirit
Copy link
Author

That could work but now that I think about it if line 839 (lockargs=()) was moved before line 833 (init_config) this could be achieved without even having to use a prelock script by just adding lockargs+="--ignore-empty-password" to the config, which I think would be much cleaner than making an entire prelock script for this use case.

SebTM added a commit that referenced this issue Sep 17, 2021
…ults twice

* Change declaration of lockargs with "-n" as default because currently we always launch in "non-forking" mode. This makes lockargs also overwritable/extendable in config/hooks. (#188)
* Add $dunst_enabled to let user in config (on runtime) determinate if dunst is enabled in current environment (#284)
* Improve pre & post-Lock to call user-hooks (#245)
* Fixed bug displaying keyboard-layout even when "--show-layout" is not present (#279)
* Bugfix for displays set to higher DPI (thanks to @jeffmhubbard - #287)
* Migrated suspend-command to config for easier adjustments (#137, #174)
@SebTM SebTM mentioned this issue Sep 17, 2021
SebTM pushed a commit that referenced this issue Oct 9, 2022
…ly we always launch in "non-forking" mode. This makes lockargs also over-writable/extendable in config/hooks. (#188)

* Add $dunst_enabled to let user in config (on runtime) determinate if dunst is enabled in current environment (#284)
* Improve pre & post-Lock to call user-hooks (#245)
* Fixed bug displaying keyboard-layout even when "--show-layout" is not present (#279)
* Bugfix for displays set to higher DPI (thanks to @jeffmhubbard - #287)
* Migrated suspend-command to config for easier adjustments (#137, #174)
SebTM pushed a commit that referenced this issue Oct 9, 2022
…ly we always launch in "non-forking" mode. This makes lockargs also over-writable/extendable in config/hooks. (#188)

* Add $dunst_enabled to let user in config (on runtime) determinate if dunst is enabled in current environment (#284)
* Improve pre & post-Lock to call user-hooks (#245)
* Fixed bug displaying keyboard-layout even when "--show-layout" is not present (#279)
* Bugfix for displays set to higher DPI (thanks to @jeffmhubbard - #287)
* Migrated suspend-command to config for easier adjustments (#137, #174)
SebTM pushed a commit that referenced this issue Oct 9, 2022
…ly we always launch in "non-forking" mode. This makes lockargs also over-writable/extendable in config/hooks. (#188)

* Add $dunst_enabled to let user in config (on runtime) determinate if dunst is enabled in current environment (#284)
* Improve pre & post-Lock to call user-hooks (#245)
* Fixed bug displaying keyboard-layout even when "--show-layout" is not present (#279)
* Bugfix for displays set to higher DPI (thanks to @jeffmhubbard - #287)
* Migrated suspend-command to config for easier adjustments (#137, #174)
SebTM pushed a commit that referenced this issue Oct 9, 2022
…ly we always launch in "non-forking" mode. This makes lockargs also over-writable/extendable in config/hooks. (#188)

* Add $dunst_enabled to let user in config (on runtime) determinate if dunst is enabled in current environment (#284)
* Improve pre & post-Lock to call user-hooks (#245)
* Fixed bug displaying keyboard-layout even when "--show-layout" is not present (#279)
* Bugfix for displays set to higher DPI (thanks to @jeffmhubbard - #287)
* Migrated suspend-command to config for easier adjustments (#137, #174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants