fix: for laravel-ide-helper's 1505 issue; #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem: param's generic type and description cancel out one another which looses description;
|
Can you make a test covering this change? |
|
@mfn Added test data cases. It actually works as expected without changes if there's no blank space between generics types, eg in @param array<int,string> $noSpace This will work OK without this PR
@param array<int, string> $withSpace This will work OK after this PR |
|
I never seen/worked with this code. Do you know why the split limit is needed at all? 🤔 |
|
Can't tell for sure. Probably to not deal with splitted description parts.
I assume it will work just fine with $limit set to 0 or -1 (no limit) as it
has implode for the remaining parts, but at some point that limit might've
been logical.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Param's generic type and description cancel out one another which lose description in the end.
This should fix barryvdh/laravel-ide-helper#1505