Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding of messages can be chained #1449

Closed
wants to merge 2 commits into from
Closed

Adding of messages can be chained #1449

wants to merge 2 commits into from

Conversation

alex-i07
Copy link
Contributor

fixes #1376

Allow to call debugbar()->emergency('message #1')->alert('message #2')->critical('message #3').

erikn69
erikn69 reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@erikn69 erikn69 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this??

laravel-debugbar/src/Facades/Debugbar.php

Lines 7 to 20 in 27b088a

/**
* @method static LaravelDebugbar addCollector(DataCollectorInterface $collector)
* @method static void addMessage(mixed $message, string $label = 'info')
* @method static void alert(mixed $message)
* @method static void critical(mixed $message)
* @method static void debug(mixed $message)
* @method static void emergency(mixed $message)
* @method static void error(mixed $message)
* @method static LaravelDebugbar getCollector(string $name)
* @method static bool hasCollector(string $name)
* @method static void info(mixed $message)
* @method static void log(mixed $message)
* @method static void notice(mixed $message)
* @method static void warning(mixed $message)

laravel-debugbar/src/LaravelDebugbar.php

Lines 48 to 56 in 27b088a

* @method void emergency(...$message)
* @method void alert(...$message)
* @method void critical(...$message)
* @method void error(...$message)
* @method void warning(...$message)
* @method void notice(...$message)
* @method void info(...$message)
* @method void debug(...$message)
* @method void log(...$message)

@alex-i07
Copy link
Contributor Author

Do you mean messages must be added like this debugbar()->alert('1st message', '2nd message', '3rd message');?
Assume several messages must be added and each is different psr-3 level, in this case chaining looks cleaner then call each one in new line

@erikn69
Copy link
Contributor

erikn69 commented Aug 30, 2023 •
edited

Do you mean messages must be added like this debugbar()->alert('1st message', '2nd message', '3rd message');?

I'm not talking about that, I'm talking about the return void, that must be return LaravelDebugbar
without that IDEs give "alert" method not found on debugbar()->emergency('message #1')->alert('message #2')

@alex-i07
Copy link
Contributor Author

alex-i07 commented Aug 31, 2023 •
edited

I'm not talking about that, I'm talking about the return void, that must be return LaravelDebugbar
without that IDEs give "alert" method not found on debugbar()->emergency('message #1')->alert('message #2')

Sorry for my misunderstanding, you are right. I fixed that.

@parallels999
Copy link
Contributor

It should follow the guidelines of psr/log,
they are supposed to return void, look php-fig/log@4f25c9a

@barryvdh barryvdh closed this Feb 13, 2024
@barryvdh
Copy link
Owner

yes we follow psr/log for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikn69 erikn69 erikn69 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: create a chain
4 participants
@alex-i07 @erikn69 @parallels999 @barryvdh