Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Change the navigation bar generation #414

Open
CrSjimo opened this issue Nov 11, 2023 · 1 comment
Open

[Feature] Change the navigation bar generation #414

CrSjimo opened this issue Nov 11, 2023 · 1 comment
Labels
triage Issues waiting to be inspected

Comments

@CrSjimo
Copy link

CrSjimo commented Nov 11, 2023

In source code /src/components/Header/src/Navigation.vue:

<span class="relative z-50" v-if="locale">
  {{ route.i18n[locale] }}
</span>
<span class="relative z-50" v-else>{{ route.name }}</span>

In the v-if="locale" branch, there should be an extra if-branch to check whether the name of a custom menu is set but the i18n of it is not set. In this case, the name should be set to the content of <span> as a fallback, otherwise the content would be blank.

Also, if the name is the same in all languages, it could be OK to just set one name instead of repeating it in i18n.

@bennyxguo
Copy link
Member

Good point, I will check on this one.

@bennyxguo bennyxguo added the triage Issues waiting to be inspected label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues waiting to be inspected
Projects
None yet
Development

No branches or pull requests

2 participants