Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow localization for footnote tooltip #4383

Open
niknetniko opened this issue Nov 6, 2022 · 6 comments
Open

Allow localization for footnote tooltip #4383

niknetniko opened this issue Nov 6, 2022 · 6 comments
Assignees
Milestone

Comments

@niknetniko
Copy link

The title attribute/tooltip for links to footnotes is not translatable.
For example, in html5, it is hardcoded here.

This means you can't convert the "View footnote" to other languages:
image

I would expect it to be translatable like other attributes (such as toc title, etc.).

@mojavelinux
Copy link
Member

I had completely overlooked that. Great point!

What name (or names) do you propose for customizing this value?

@mojavelinux mojavelinux added this to the v2.1.x milestone Nov 6, 2022
@niknetniko
Copy link
Author

Looking at some of the other names, perhaps something along the lines of footnote-tooltip?

@mojavelinux
Copy link
Member

That's a good candidate. What do you think about footnote-hint to be more generic?

@niknetniko
Copy link
Author

Even better 👍

mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Nov 2, 2023
@mojavelinux
Copy link
Member

mojavelinux commented Nov 2, 2023

I just submitted a PR to implement this. Here are the attributes I settled on in that proposal:

  • view-footnote-tip - used for the title/tooltip on a footnote number
  • unresolved-footnoteref-tip - used for the title/tootip on an unresolved footnote reference

I went back and forth between hint and tip...but since it appears as a tooltip, "tip" seems like a reasonable compromise.

@mojavelinux mojavelinux self-assigned this Nov 2, 2023
@mojavelinux
Copy link
Member

mojavelinux commented Nov 26, 2023

I'm thinking about renaming view-footnote-tip to just footnote-tip. It's the tip that shows on the footnote itself, so I don't think the name needs to suggest what it should say.

If we really wanted to match the underlying terminology, it would be footnotedef-tip, but that doesn't look very clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants