Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fallbackUri issue #5494

Open
1 task done
RayayChung opened this issue Mar 16, 2024 · 0 comments
Open
1 task done

[BUG] fallbackUri issue #5494

RayayChung opened this issue Mar 16, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@RayayChung
Copy link
Contributor

RayayChung commented Mar 16, 2024 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

fallback config:
image

when fallback is triggered, the ip:port info is missing from the fallback request.
image

From the current code, it appears that this fallbackUri field supports two configuration methods(eg. fallback:/far/boo or http://ip:port/far/boo). Does this align with our expectations?

Expected Behavior

No response

Steps To Reproduce

No response

Environment

ShenYu version(s): 2.6

Debug logs

No response

Anything else?

No response
@RayayChung RayayChung added the type: bug Something isn't working label Mar 16, 2024
RayayChung pushed a commit to RayayChung/shenyu that referenced this issue Mar 16, 2024
[ISSUE apache#5494] fix fallback issue
98c0d83
RayayChung pushed a commit to RayayChung/shenyu that referenced this issue Mar 16, 2024
[ISSUE apache#5494] add javadoc
2f55648
RayayChung pushed a commit to RayayChung/shenyu that referenced this issue Mar 16, 2024
[ISSUE apache#5494] fix fallback issue
b307a16
RayayChung pushed a commit to RayayChung/shenyu that referenced this issue Mar 16, 2024
[ISSUE apache#5494]
7528926 
* avoid redirect loop
* add unit test
RayayChung pushed a commit to RayayChung/shenyu that referenced this issue Mar 20, 2024
[ISSUE apache#5494] fix code issue
f8882d5
moremind added a commit that referenced this issue Mar 22, 2024
@RayayChung @yu199195 @moremind
[type: BUG] fix hot load issue (#5509)
f578281 
* [ISSUE #5508] fix hot load issue

* [ISSUE #5494] fix code issue

---------

Co-authored-by: ray <zhongzhenchao@ingbaobei.com>
Co-authored-by: xiaoyu <xiaoyu@apache.org>
Co-authored-by: moremind <hefengen@apache.org>
yu199195 added a commit that referenced this issue Apr 24, 2024
@RayayChung @moremind
@yu199195 @loongs-zhang
[type: BUG] fix fallback issue (#5496)
9dbb39e 
* [ISSUE #5494] fix fallback issue

* [ISSUE #5494]
* avoid redirect loop
* add unit test

---------

Co-authored-by: ray <zhongzhenchao@ingbaobei.com>
Co-authored-by: moremind <hefengen@apache.org>
Co-authored-by: xiaoyu <xiaoyu@apache.org>
Co-authored-by: loongs-zhang <zhangzicheng@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RayayChung