Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support ratelimit for topic or client ip #8173

Open
yuz10 opened this issue May 20, 2024 · 2 comments · May be fixed by #8174
Open

[Feature] support ratelimit for topic or client ip #8173

yuz10 opened this issue May 20, 2024 · 2 comments · May be fixed by #8174
Labels
type/new feature

Comments

@yuz10
Copy link
Member

yuz10 commented May 20, 2024

Is Your Feature Request Related to a Problem?

Add ratelimit for a special topic or client ip.
mainly for the following reasons:

  1. some topics or clients use too much tps, that will affect other topics or clients.
  2. when a consumer read code data, the pagecache is polluted, and will affect read hot data.
  3. when a consumer read too fast, the downstream services may be unstable.

Describe the Solution You'd Like

add ratelimit support for topic or client ip, which is dynamic configured in broker.

Describe Alternatives You've Considered

not yet

Additional Context

No response
@yuz10 yuz10 linked a pull request May 20, 2024 that will close this issue
Open
@dingshuangxi888
Copy link
Contributor

Is this rate limiting feature only effective for consumers?

@yuz10
Copy link
Member Author

yuz10 commented May 23, 2024

Producers are also effective , when creating a ratelimit rule, consume tps and produce tps can be specified seperately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8173] support ratelimit for topic or client ip yuz10/rocketmq
2 participants
@dingshuangxi888 @yuz10