Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] optimize produceAccumulator #8134

Open
1 task done
Willhow-Gao opened this issue May 14, 2024 · 0 comments · May be fixed by #8135
Open
1 task done

[Enhancement] optimize produceAccumulator #8134

Willhow-Gao opened this issue May 14, 2024 · 0 comments · May be fixed by #8135
Labels
type/enhancement

Comments

@Willhow-Gao
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

ProduceFAccumulator#send(SendCallback sendCallback) method has a parameter that is never used.A more reasonable approach is to remove the parameters and rename
image

Motivation

No necessary parameters passed

Describe the Solution You'd Like

remove parameter and rename method

Describe Alternatives You've Considered

Not consider

Additional Context

No response
Willhow-Gao added a commit to Willhow-Gao/rocketmq that referenced this issue May 14, 2024
@Willhow-Gao
[ISSUE apache#8134] optimize ProduceAccumulator
d51e38f
@Willhow-Gao Willhow-Gao linked a pull request May 14, 2024 that will close this issue
Open
@Willhow-Gao Willhow-Gao changed the title [Enhancement] optimize produceFAccumulator [Enhancement] optimize produceAccumulator May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8134] optimize ProduceAccumulator Willhow-Gao/rocketmq
1 participant
@Willhow-Gao