New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [Resource] unable to access file in resource center #16006

Closed

2 of 3 tasks

caishunfeng opened this issue May 16, 2024 · 1 comment · Fixed by #16102

Closed

2 of 3 tasks

[Bug] [Resource] unable to access file in resource center #16006

caishunfeng opened this issue May 16, 2024 · 1 comment · Fixed by #16102

Labels

bug priority:high

Contributor

caishunfeng commented May 16, 2024

Search before asking

I had searched in the issues and found no similar issues.

What happened

The url is:
http://127.0.0.1:5173/resource/file/subdirectory?prefix=file:/dolphinscheduler/default/resources/test/&tenantCode=default

What you expected to happen

Can access the legal file normally.

How to reproduce

startup ds at local
create resource dir / file
then try to access it.

Anything else

No response

Version

dev

Are you willing to submit PR?

Yes I am willing to submit a PR!

Code of Conduct

I agree to follow this project's Code of Conduct

caishunfeng added bug Waiting for reply labels

Contributor Author

caishunfeng commented May 16, 2024

dolphinscheduler/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/CheckUtilsTest.java

Line 109 in 68a1906

Assertions.assertFalse(CheckUtils.checkFilePath("file://xxx/ss"));

It seems file:// is illegal path but the url prefix is file:/.

ruanwenjun added priority:high and removed Waiting for reply labels

caishunfeng mentioned this issue

Revert "[Improvement] Abnormal characters check" #16102

Merged

SbloodyS closed this as completed in #16102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment