Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a unit to an existing quantity? #1246

Open
jasekiw opened this issue May 4, 2023 · 3 comments
Open

How to add a unit to an existing quantity? #1246

jasekiw opened this issue May 4, 2023 · 3 comments
Labels

Comments

@jasekiw
Copy link

jasekiw commented May 4, 2023

I am trying to add a custom unit for our project that should go under ElectricResistivity. It is MeterPerSiemens (m/S) and is a 1 to 1 conversion to OhmMeter.

I tried following the documentation below however it only gives examples on how to add a custom quantity with units. I want to add a unit to an existing quantity (ElectricResistivity), not a new one.
https://github.com/angularsen/UnitsNet/wiki/Extending-with-Custom-Units

How would I go about adding a unit to an existing quantity? Once that is determined, I think the documentation should be updated to include the instructions.

@jasekiw jasekiw added the bug label May 4, 2023
@angularsen
Copy link
Owner

Hi, I've added some more info to the top of the wiki page. In particular, why adding units to existing quantities is currently not feasible.

Please take a look and let me know if it helps or how it could improve further:
https://github.com/angularsen/UnitsNet/wiki/Extending-with-Custom-Units

@jasekiw
Copy link
Author

jasekiw commented May 8, 2023

@angularsen Thank you for the section in the documentation. It makes it much more clear. Seeing as it's not possible to add a unit, would this unit be a candidate to officially add it to the library? I don't want to go through the effort of creating a PR if it is going to get denied. Thanks!

@angularsen
Copy link
Owner

Yes, that sounds reasonable to add.
Please go ahead with the pull request, just follow the instructions in the wiki and ping me if you have any questions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants