String format in non english cultures

[lenyturmel]

Hi all

I have two questions about formatting units and quantities

1. I am not able to find how to format a quantity using the long name of the unit
   Example:
   Volume.FromLiters(1) //I would prefer "1 liter" and not "1 L"

2. I am not able to find how add new cultures for the ToString of units
   Example:

Thread.CurrentThread.CurrentUICulture = Language.Fr.ToCulture();
VolumeUnit.Liter.ToString();  //I would like to get "Litre" and not "Liter

Could you please help me and give some entry points or sample in order to do that ?
Thank you for your help (and thank you for this awesome library)

[angularsen]

Hi,

ToString with long unit name

There is no support for long form names yet, sorry. We could add support for it similar to how we define abbreviations for different cultures: https://github.com/angularsen/UnitsNet/blob/master/Common/UnitDefinitions/Volume.json#L8-L25.

Localize unit name

Again, we support localization of abbreviations like "kg" and "cm", but currently no localization support for quantity name "Length" or unit name "Meter".

Would you be interested in attempting a pull request on either of these?
Relevant #890, #397 .

[angularsen]

@lenyturmel Please push a branch and create a pull request, so we can discuss details there.

I think I have to have similar classes to UnitValueAbbreviationLookup and UnitAbbreviationsCache. Do you confirm ?

Yes, that sounds like a good approach.

I think we could rename UnitAbbreviationsCache as UnitNamesCache or UnitLocalizationCache and make this class to expose the following public methods:

That would be fine, but we can't make breaking changes of public types and members without bumping major version, so either

• Create a new class and mark the old one [Obsolete("Use XXX instead.")]
• Create a new class for this purpose alone and extract any private/internal code in the unit abbreviation classes if you want to reuse it.
• Live the wrong name for now, add a TODO comment and mention it in v5: Wishlist for breaking changes #180 for a future rename.

Without knowing any details, I would generally favor nr 2 or 3.

For the lookup class, I can see 2 options:

It sounds like you are going in the right direction. Let's get a PR going and we have some code to look at and get a feel of. Also, having some unit tests to verify how it will be used and that it actually works can be very helpful. See how tests are written for the existing stuff. Don't need a ton of tests, just a few to verify your idea as a start.

[lenyturmel]

Hi Andreas
I tried to push my current branch with my work in progress but it looks like I do not have access rights to push branches :
`$ git push origin xp/localize-unit-names
Select an authentication method for 'https://github.com/':

1. Web browser (default)
2. Personal access token
   option (enter for default): 1
   info: please complete authentication in your browser...
   remote: Permission to angularsen/UnitsNet.git denied to lenyturmel.
   fatal: unable to access 'https://github.com/angularsen/UnitsNet.git/': The requested URL returned error: 403`

I tried with the Git console, and Githhub Deskstop but I have the same problem when I try to push my branch on your remote repo

I did never collaborate on a Github project (I work with AzureDevOps or Gitlab). You are not supposed to add me as a collaborator to give me such an authorization ?

Sorry for the troubles

[angularsen]

@lenyturmel No problem. You need to fork the repo and create a pull request from a branch on your fork to this repo.

Some guidance here:
https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#6-create-pull-request

Please ask if you get stuck, I'm happy to assist.

[angularsen]

Direct link:
https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

[lenyturmel]

Thank you for your help. I was able to fork the repo , to push my branch and to create a pull request as a draft (so you can follow my work)
I will try to work asap
thanks