-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Pack Addition Error and Adding Copy Feature #882
Comments
Hi @andrew-bierman, @EngrAJ8888 , I am getting an error on adding item to pack: |
Hi @Isthisanmol, I've checked the live version, and two items are already fixed. The only task left is to add the copy option. Thank you for working on this one! :) |
Hi @EngrAJ8888, I have checked the second issue on native. It was not working as expected so I fixed it on native. Please check PR: #900 and tell me if any issues or updates.Thanks. |
Hi @Isthisanmol , thank you for making the updates! I'd also like to add this item to the list of needed updates:
|
hi @Isthisanmol I want to add this also:
|
Hi @EngrAJ8888, Please check PR: #906 for the above issue and tell me if any issues or updates. |
Hi @JewelTee, I've checked this. It's not a matter of a new pack v/s an old pack. The owner of the item has the exclusive ability to edit it. When I compare two different items from the same pack, I notice that one only offers the option to delete it, while the other provides both options. This is because I am the owner of the second item, not the first one. Hence, I see both options only for the second item. I'll attach screenshots of both items for reference. |
Hi @Isthisanmol - The PR has already been merged, and I noticed that the edit and delete options for items in the pack are no longer working. Could you please take a look into it as well? Thanks! |
Hi @EngrAJ8888, please check PR: #918 and let me know if any issues or updates. |
Hi @EngrAJ8888, please check PR:#926 for the edit and delete options for items in pack and let me know if any issues or updates. |
Hi @Isthisanmol, just wanted to let you know that I've added a comment on the PR. Thanks for making the updates! |
Any issues in this? |
Hi @EngrAJ8888, please check PR: #930. I think it resolves the edit options issue. Let me know if edit option is still not working after first edit. |
Hi @JewelTee @EngrAJ8888 , please check #937. Let me know if the issue persists. |
Hi @Isthisanmol , I think there's some confusion about the update needed. The "Copy Pack" feature should be available when the owner browses packs created by other users, not on their own packs. The owner can clone packs from the Feed page and can modify the items in the cloned pack as well. Thanks! |
Should the other options on item and pack also work like delete and save on pack and delete on item. |
Hi @Isthisanmol , if you are referring to the cloned pack, yes that is correct. Users should have the ability to modify their cloned pack, with options to edit and delete. |
Please Check #937 for the latest commits. |
Updates have been confirmed and validated. This task can now be marked as closed. |
Describe the bug
https://github.com/andrew-bierman/PackRat/assets/122357250/6cca0a80-d791-4bf3-b5e1-bdeea2bdffc0
To Reproduce
Steps to reproduce the behavior:
Email: zoot3@email.com
Password: 12345678
Expected behavior
The text was updated successfully, but these errors were encountered: