Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Proposal] Audio to the Subtitles based on Scroll #27

Open
shravan20 opened this issue Mar 3, 2021 · 5 comments
Open

[Feature Proposal] Audio to the Subtitles based on Scroll #27

shravan20 opened this issue Mar 3, 2021 · 5 comments

Comments

@shravan20
Copy link

Audio to the Subtitles Feature Proposal

Description

Based on the scroll, as the srt(subtitles appear, an audio reading that subtitle will run in background)

Assignees

@shravan20

Background

Using Audio Element and its DOM API, we can implement this into the application without any performance hinderance

Tests

Unit testing will also be taken care and completed using existing Test Library used for the same.

@hyper-dot
Copy link

https://www.youtube.com/watch?v=S7V0-QvYbdo&t=653s

here a youtuber have done for you. skip to 10.20

you are so inspiring for me I am also learning to code by my self.
You are amazing.

@asos-albinotonnina
Copy link
Collaborator

asos-albinotonnina commented Mar 12, 2021

@shravan20 Thank you so much! This could actually be quite a nice feature! Do you feel like working on a PR? That'd be awesome :)

@asos-albinotonnina
Copy link
Collaborator

@Roshanpaudel111 I'm honored 🙏

@Ritarshi-Chattaraj
Copy link

I love your website! It's so cool! I would like to work on PR building this feature.

@shravan20
Copy link
Author

@shravan20 Thank you so much! This could actually be quite a nice feature! Do you feel like working on a PR? That'd be awesome :)

I would like to contribute to it. I will raise the PR upon completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants