Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change various visitor implementations from structs to classes #42

Open
charrondev opened this issue Dec 4, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@charrondev
Copy link
Contributor

This project implements various visitor classes that have methods for generating or rendering each type of markup.

I'd like to switch these structs to be classes and add the ability to replace their implementation in the ParserBuilder.

By making them classes they can be extended while preserving most functionality.

For example I have a fair of experimentation I'd like to do with tables in the near future that likely won't be immediately upstreamable and would prefer not to create a full duplicate implementation of all of the other visitor functions.

@zhgchgli0718 zhgchgli0718 self-assigned this Dec 11, 2023
@zhgchgli0718
Copy link
Member

Any adjustments that make the structure more streamlined and stable are highly welcome.
I can assist with reviewing and adjusting test cases.

Additionally, if you are interested, you can also join as a maintainer for this project.
Thank you.

@zhgchgli0718 zhgchgli0718 added question Further information is requested enhancement New feature or request and removed 2023Q4 question Further information is requested labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants