Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from craftlib-chat to adventure #19

Open
NickAcPT opened this issue Aug 31, 2020 · 4 comments
Open

Move from craftlib-chat to adventure #19

NickAcPT opened this issue Aug 31, 2020 · 4 comments

Comments

@NickAcPT
Copy link

Is your feature request related to a problem? Please describe.
Adventure appears to be more established when it comes to dealing with chat messages. It has many features that this project can inherit from using it.

It abstracts Text components, boss-bars, sounds, and they even have an NBT API if you need (provided you also want to migrate from yours).

Describe the solution you'd like
Stop using craftlib-chat and move to adventure.

Although, I understand if you don't want to make the move into something made by another person/team.
Either way, thanks for the time and effort you put into this project!

@NickAcPT NickAcPT changed the title Convert craftlib-chat to adventure Move from craftlib-chat to adventure Aug 31, 2020
@halotroop2288
Copy link

I'm going to make an attempt at implementing this in a PR. Wish me luck!

@sexnine
Copy link

sexnine commented Feb 6, 2023

Hey @Zerite / @KodingDev, could we please get your thoughts on this issue?

Are you guys open to switching to, or at least supporting Adventure for Chat?

If so, I can also have a go at implementing this and submitting a PR.
If this is something that you guys would not like, I won't bother.

@KodingDev
Copy link
Member

This library was created mainly as a wholistic re-implementation of MC tech. From the beginning I didn't want to rely on any external libraries and rather create them all in-house. I stopped having time to maintain the library unfortunately, and - while I was going to focus on a rewrite in the years following - libraries such as adventure now replace a lot of the stuff I was planning to re-implement.

tldr; Don't worry about creating a PR to swap in adventure support, the lib has some core architectural flaws which need addressing regardless.

@sexnine
Copy link

sexnine commented Feb 6, 2023

This library was created mainly as a wholistic re-implementation of MC tech. From the beginning I didn't want to rely on any external libraries and rather create them all in-house. I stopped having time to maintain the library unfortunately, and - while I was going to focus on a rewrite in the years following - libraries such as adventure now replace a lot of the stuff I was planning to re-implement.

tldr; Don't worry about creating a PR to swap in adventure support, the lib has some core architectural flaws which need addressing regardless.
@KodingDev

That's no problem and I fully understand. I've started using CraftLib in a project and it's been a really nice developer experience.

If you are interested, I'm happy to help rewrite whatever parts of the library need addressing and help maintain the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants