-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valgrind: Conditional jump or move depends on uninitialised value #291
Comments
Is this a bug in openssl? |
I honestly hope not. ;) If I were to guess, I would look for uninitialized padding bytes (or unused member variable) in some structure being passed to openssl and treated as byte buffer there. But this is really just a wild guess. Can you replicate it with valgrind in your tests? |
Can you run your test with 36fc6f8 ? Also, if you have a test setup to compile and run tests with valgrind, I would like to add that to my test suite. I would pull your change if you know the relevant cmake. Everything in cmake is so slow for me, this is not likely to be something I would do on my own. |
Oops, one more. 7f98753 |
test_crypto: (click to expand)
This one unfortunately does not report the origin of the uninitialized variable. test_connection suite-quick (CUtlMemoryBase::Grow): (click to expand)
test_connection suite-quick (libcrypto): (click to expand)
This one shows the variable is inside libcrypto, which is indeed worrying. |
I'll take a look at the BReallySendRawPacket one. The ones inside SSL with AES_GCM_DecryptContext::Decrypt: Do you agree that if any of those arguments were uninitialized, with my changes they should have fired in my code? (Just want a sanity check that my changes should have detected any bug on my side.) |
I get an error detected by valgrind when running my tests.
I am compiling the code with g++ version 12 running on ubuntu 22 with valgrind tool memcheck.
Please let me know if you need any more information.
The text was updated successfully, but these errors were encountered: