Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: App Not Drawing Behind Navigation Bar on Patching Screen #1783

Open
4 tasks done
Dan-Banfield opened this issue Mar 24, 2024 · 4 comments
Open
4 tasks done

bug: App Not Drawing Behind Navigation Bar on Patching Screen #1783

Dan-Banfield opened this issue Mar 24, 2024 · 4 comments
Labels
Bug report Something isn't working

Comments

@Dan-Banfield
Copy link

Bug description

On the patching screen, it seems the app is not in edge-to-edge mode because it does not draw behind the system navigation bar.

1000020943

Version of ReVanced Manager and version & name of app you are patching

Version 1.19.3
App being patched: any

Installation method

Regular

ReVanced Manager logs

Not relevant.

Patch logs

Not relevant.

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager
@Dan-Banfield Dan-Banfield added the Bug report Something isn't working label Mar 24, 2024
@snehithssv
Copy link

So, while on patching screen, the bottom nav-bar should be hidden?? @Dan-Banfield

@Dan-Banfield
Copy link
Author

So, while on patching screen, the bottom nav-bar should be hidden?? @Dan-Banfield

No, not hidden, just the app should draw behind it in-line for the upcoming mandate in Android 15.

@snehithssv
Copy link

snehithssv commented Jun 11, 2024

No, not hidden, just the app should draw behind it in-line for the upcoming mandate in Android 15.

So, app is to be forced to be in edgeToEdge instead of leanBack/immersive.?
More like this...??
Screenshot_1718089769

And if yes, should it be this way only in patch screen on for the whole application??

@Dan-Banfield
Copy link
Author

In the screenshot you provided, the navigation bar at the bottom is still black. Instead, it should be drawn behind. Please see: https://developer.android.com/about/versions/15/behavior-changes-15#:~:text=Edge-to-edge%20enforcement,because%20most%20components%20apply%20insets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants