Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in docs minor conflict with the --show-failed-attempts and --clock flag #298

Open
Akhil-CM opened this issue Mar 17, 2024 · 0 comments

Comments

@Akhil-CM
Copy link

This issue is a....

[ ] Bug
[x] Other kind of issue (Please describe in detail)

Current Behavior

This doesn't seem like an issue at all. Just mentioning here for documentation purposes. The --show-failed-attempts flag has a minor conflict with the --clock flag. When the former is enabled, the clock is only shown till the first failed attempt. After that the number of failed attempts is shown instead of the clock.

Expected Behavior

Maybe mention about this in README and manpages. I don't think any code changes needs to be made. As seeing the clock doesn't really matter after trying the passwd.

Reproduction Instructions

The example script in the README can be modified to show this:

#!/bin/sh

BLANK='#00000000'
CLEAR='#ffffff22'
DEFAULT='#ff00ffcc'
TEXT='#ee00eeee'
WRONG='#880000bb'
VERIFYING='#bb00bbbb'

i3lock \
--insidever-color=$CLEAR     \
--ringver-color=$VERIFYING   \
\
--insidewrong-color=$CLEAR   \
--ringwrong-color=$WRONG     \
\
--inside-color=$BLANK        \
--ring-color=$DEFAULT        \
--line-color=$BLANK          \
--separator-color=$DEFAULT   \
\
--verif-color=$TEXT          \
--wrong-color=$TEXT          \
--time-color=$TEXT           \
--date-color=$TEXT           \
--layout-color=$TEXT         \
--keyhl-color=$WRONG         \
--bshl-color=$WRONG          \
\
--screen 1                   \
--blur 5                     \
--clock                      \
--indicator                  \
--time-str="%H:%M:%S"        \
--date-str="%A, %Y-%m-%d"    \
--keylayout 1                \
--show-failed-attempts # <------ added here

Environment

Output of i3lock --version:

i3lock version:
`i3lock: version 2.13.c.5 © 2010 Michael Stapelberg, © 2015 Cassandra Fox, © 2021 Raymond Li`

Where'd you get i3lock-color from?

[x] AUR package (which one?)
[ ] Built from source yourself
[ ] Other (Please describe in detail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant