Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When new release? Modifier keys updated on i3lock #281

Open
alexandru0-dev opened this issue Jul 4, 2023 · 3 comments
Open

When new release? Modifier keys updated on i3lock #281

alexandru0-dev opened this issue Jul 4, 2023 · 3 comments
Labels

Comments

@alexandru0-dev
Copy link

i3lock is at release 2.14.1.
When is i3lock-color planning to make the new release?

The main reason for asking is bc I wanted the keyboard modifiers to show when typing
(see the issue in i3#225)
Tho a quick look of the commits shows that they added a -k flag for this, going into conflict with the option -k of this fork
(see 3b6511d)

i3lock i3lock-color
-k flag forces keeb modifiers clock
@Raymo111
Copy link
Owner

Raymo111 commented Aug 1, 2023

There's been a lot of breaking changes from upstream, including moving from M4 to meson. I couldn't even cherry-pick that commit over because of the conflicting option. I'm not planning on doing a merge from upstream in a while, but:

  1. I did release 2.13.c.5 a couple days ago, and
  2. If someone else feels like merging from upstream I'll be happy to review the PR.

@Raymo111 Raymo111 added the info label Aug 1, 2023
@alexandru0-dev
Copy link
Author

@Raymo111 Thanks for the info.
This afternoon I'm going to look into the commits and try to bump up the version.

How should the -k behave tho?
It's going to be a braking change with previous configs if the new behavior is chosen.
Should I maintain the -k for the clock or should I follow the original repo (with the keyboard option)?

@Raymo111
Copy link
Owner

Raymo111 commented Aug 1, 2023

Let's not break existing workflows, the new option can just have a long opt and not a short one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants