Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiDPI support #11

Open
skyline75489 opened this issue Mar 4, 2021 · 6 comments
Open

HiDPI support #11

skyline75489 opened this issue Mar 4, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@skyline75489
Copy link

Right now the support for HiDPI and DPI changing event seems missing.

@McYoloSwagHam
Copy link
Owner

Could you explain what you mean?
Do you mean the situation when you move a window from one monitor to another and they have different DPIs?

@skyline75489
Copy link
Author

Sorry I wasn't being clear. I mean I was changing the DPI of the current monitor. Like from 100% to 200%.

@McYoloSwagHam
Copy link
Owner

Is this something you do commonly, changing DPIs of your monitor?
I can't really see a common use case for changing DPIs of your monitor as you work.
Regardless, when crash handling and restarting with memory/layout will be implemented, I'm sure this problem will disappear since WinWM would just restart with the new DPI

@skyline75489
Copy link
Author

Yeah.. my use case might be unusual. The DPI change happens when I remote login a Windows machine using a device that has different DPI than that machine via RDP.

@McYoloSwagHam
Copy link
Owner

So as far as I understand, the way to resolve this would be to handle WM_WHATEVER_DPI_CHANGE, and scale the windows accordingly, right?

@McYoloSwagHam
Copy link
Owner

Update: Upon further inquiry, this is harder than it looks, WM_DPICHANGED does not supply the HMONITOR whose DPI changed making it very hard to update the windows who are affected by the DPI change.

And using verify_workspace seems to fix the workspace (mod+r)

@McYoloSwagHam McYoloSwagHam added the enhancement New feature or request label Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants