Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Librecad doesn't cancel 'Close' #1764

Open
NabilAKROUD opened this issue Apr 24, 2024 · 4 comments
Open

Librecad doesn't cancel 'Close' #1764

NabilAKROUD opened this issue Apr 24, 2024 · 4 comments
Labels
missing data the issue is vague because of missing data

Comments

@NabilAKROUD
Copy link

When in
File > Close > Cancel

It close the open file instead of canceling.

@lordofbikes lordofbikes added the missing data the issue is vague because of missing data label Apr 24, 2024
@perepujal
Copy link
Contributor

Reproduce as Start LibreCad with an empty drawing, draw a line, not save the drawing, hit File -> Close
A dialog "Closing Drawing" appears with three options, Save, Close, Cancel

One could assume that "Save" will save the drawing and close the file, "Close" would close the file without saving. and "Cancel" will not save the drawing nor close the file and will return to the drawing.

Currently, "Cancel" closes the file as if you hit "Close"
HTH
Pere

@perepujal
Copy link
Contributor

Strange, If I click on the window manager close button I get the same dialog, but then "Cancel" works as expected.

@dxli
Copy link
Member

dxli commented Apr 28, 2024

the action queue needs a review:

we currently keep suspended actions in a stack, but validation of those actions appears to be weak.

@NabilAKROUD
Copy link
Author

NabilAKROUD commented May 9, 2024

I made a short video showing that the [Cancel] button doesn't did what it should do.
I experienced this issue now on windows 10/11 in different versions of LC.

Recording.2024-05-09.082729.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing data the issue is vague because of missing data
Projects
None yet
Development

No branches or pull requests

4 participants