-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Id Connect Issue #1044
Comments
This was a deliberate choice to not include that functionality (which its predecessor There are multiple issues with it (which we're working on);
More details below. Definitely interested in thoughts about how to possibly deal with those, so feedback appreciated. Incorrect OAS filesThe input to the conversion is the OAS file that describes the API, as it lives internally in the back-end. Could be generated from code, etc. Now if we want Kong to protect that API with basic-auth for example, then in the case of The problem however is that the OAS file now describes an API that doesn't exist. Since the file will in its So the file has become a weird mix of internal and external properties of the same service. Ownership and trustIn large installations we typically see multiple roles or actors in the pipelines from development to production.
Now if the The security requirements should be delivered separately (in their own flow, with their own authorizations and approvals for changes). This also allows the security folks to review only the files that input security stuff changes, instead of having to review the OAS file every time one of those many teams publishes a change. |
Hey @Tieske thanks for the response. I actually agree with the above approach. Specifically for Incorrect OAS File I felt like this was a bit odd too me as well. Based on item number 2 Ownership and Trust I think I might break the auth plugin off into a kong declarative yaml with the OpenAPI Spec being separate. The one recommendation I would have here is that if the |
I am trying to convert an Open API Spec 3 file to a declarative kong yaml. I am struggling with getting the below file to generate the appropriate open id connect plugin in the declarative kong yaml. Here is the command I run.
deck file openapi2kong -s test.yaml -o test_kong_gh.yaml
Another note about this. This works when I export it from insomnia as Kong Declarative 3.x
Input test.yaml file
Output test_kong_gh.yaml
I really like the deaK cli tool.🚀️ Great job!!
The text was updated successfully, but these errors were encountered: