Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure consistent dependency versions across packages #2028

Open
maschad opened this issue Apr 8, 2024 · 10 comments · May be fixed by #2235
Open

chore: ensure consistent dependency versions across packages #2028

maschad opened this issue Apr 8, 2024 · 10 comments · May be fixed by #2235
Assignees
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute p2 Low Priority
Milestone

Comments

@maschad
Copy link
Member

maschad commented Apr 8, 2024

We have some multiple packages requiring the same dependency with different the versions it would be useful to sync them using something like syncpack

@maschad maschad added chore Issue is a chore good first issue Suitable for newcomers looking to contribute labels Apr 8, 2024
@richardgreg
Copy link
Contributor

Giving this a go

@maschad
Copy link
Member Author

maschad commented Apr 8, 2024

Awesome! Thanks for looking into this.

@richardgreg
Copy link
Contributor

Hi @maschad, do you have experience with syncpack? I'm struggling to create a configuration that gives us the exact solution we want. They somehow seem to come out mismatched even when the rule applies to all dependencies

@JamieMason
Copy link

I can try and help @richardgreg, what are you trying to configure?

@richardgreg
Copy link
Contributor

Hi @JamieMason, thanks for offering to help.

I want to configure .syncpackrc to accomplish the goal (ensure consistent dependency versions across packages) after I run syncpack fix-mismatches and then pnpm update` command. So far, only some packages get updated from my effort. 😅

@JamieMason
Copy link

No problem @richardgreg. If you can give me some information on which packages you are expecting to change but don't, I'll do my best to try and help you.

@richardgreg
Copy link
Contributor

I used @typescript-eslint/types as a reference. I expect that all instances of the package will be version 6.12.0. I think if we can come up with a general config, not mentioning any particular package, that fixes that, then it should apply to other packages as well 🙂

@JamieMason
Copy link

When I search for @typescript-eslint/types in your branch chore/packages-dependency-consistency there are no results?

@richardgreg
Copy link
Contributor

@JamieMason, you can take a look now. I configured synckpack to ignore local packages, as I assumed the team would prefer.

@JamieMason
Copy link

Ok great, let me know if you have any questions or you notice something which you don't think is right and I can try and help you. You're not using @typescript-eslint/types in your project so I'm guessing whatever that was is resolved.

@richardgreg richardgreg linked a pull request May 5, 2024 that will close this issue
@arboleya arboleya added the p2 Low Priority label Jun 9, 2024
@arboleya arboleya added this to the Mainnet milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute p2 Low Priority
Projects
None yet
4 participants