Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketcher UI: Horizontal / Vertical constraints rotate with view #14110

Open
2 tasks done
maxwxyz opened this issue May 17, 2024 · 10 comments
Open
2 tasks done

Sketcher UI: Horizontal / Vertical constraints rotate with view #14110

maxwxyz opened this issue May 17, 2024 · 10 comments
Labels
Feature FR for improvements or new features UI/UX WB Sketcher Related to the Sketcher Workbench

Comments

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

When applying horizontal and vertical constraints they are displayed correctly when the sketch is viewed in the direction of the sketch plane. Same as any constraints:
grafik

When you rotate the view, all constraints stay aligned to the view so the user can read dimensions and all constraint icons. That is ideal.
The only issue is with the horizontal and vertical constraints. They also stay oriented the same way to be identified as horizontal and vertical, but they look confusing when the sketch is rotated or viewed from any other angle.

grafik

When the view is rotated 90 degrees the horizontal ones appear vertical next to a horizontal appearing line:
grafik

As these are the only constraints which are relative to the sketch orientation (axes/grid) shouldn't they be displayed always oriented aligned with the horizontal and vertical axes? CATIA for example just uses a H and V for indication.

@FreeCAD/design-working-group FYI

Full version info

0.22

Subproject(s) affected?

Sketcher

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added UI/UX Feature FR for improvements or new features WB Sketcher Related to the Sketcher Workbench labels May 17, 2024
@obelisk79
Copy link
Contributor

Well, that is quite interesting. H and V seem like reasonable substitutes, and most likely are the simplest solution to this problem. I'd wait for others to weigh in, but my initial reaction is to support this.

@pierreporte
Copy link

pierreporte commented May 17, 2024

Even the Catia implementation isn’t ideal. When you’re applying an H or V constrain when the view is rotated, you’ll make the mistake half the time or more. My favourite solution so far is what Solid Edge does: drawing + crosses at the center of the line, in the sketch plane, aligned with the lines. It has two drawbacks: it needs merged H/V constrains (which wasn’t very popular in the FreeCAD community, but it solves the sketch orientation problem) and competes with midpoint. Pictures below.

image

image

image

image

@pierreporte
Copy link

I would say that, if the Solid Edge solution was to be implemented in some way, the cross could be displayed between all points lying on the line. If there is no intersection with the segment (except at end points), there is only one cross. If there is one intersection, there are two crosses, etc.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 17, 2024

Don't forget that you can also only align points or centerpoints horizontally. Not sure if a cross in the middle of nothing would be ideal not to confuse with symmetry. Also with points only, the rotating aspect of the horizontal and vertical constraint makes even less sense.
Normal orientation:
grafik

90 degrees:
grafik

@pierreporte
Copy link

Solid Edge draws a dashed line between points, and puts the cross on it. FreeCAD could do it in any case, it would add clarity. The thin green line system used for arcs could be used for this.

image


NX has a similar solution: there is a thick dash on the line. It’s more distinguishable from points.

image

@0penBrain
Copy link
Contributor

First question is : why would you rotate your sketch ???
Using 'H' and 'V' is not better has you'll have an 'H' close to a vertical line. I would even say current system is better because you can more easily detect you're not in the genuine orientation if you come to such a situation. ;)

@obelisk79
Copy link
Contributor

obelisk79 commented May 18, 2024

First question is : why would you rotate your sketch ???

I had this same thought, but my assumption is that a large number of CAD users like to model (and sketch presumably) in-situ. I don't think any of the other proposals above other than the H and V offer anything particularly useful, and even the H/V are only marginally useful, but that change would also not really be harmful in any way.

@0penBrain
Copy link
Contributor

but that change would also not really be harmful in any way.

AFAIK symbols are pixmaps and thus not translatable. Using "hardcoded" H/V doesn't sound very good regarding i18n.

@MisterMakerNL
Copy link
Contributor

MisterMakerNL commented May 18, 2024

I can find reasons to rotate a sketch but, but not to keep it rotated and start working on it.
It's mostly to find references.
I wouldn't even mind if the constrains where hidden when rotating. Although this would probably confuse some newbies.

@obelisk79
Copy link
Contributor

obelisk79 commented May 18, 2024

AFAIK symbols are pixmaps and thus not translatable. Using "hardcoded" H/V doesn't sound very good regarding i18n.

i18n is of course important, but in this case I think that enough major languages (nearly all latin/germanic and more) would see direct correlation, and for those which don't the letters merely become discrete symbols to learn and these aren't actual words in context here which would need direct translation. Out of curiosity I punched the words vertical and horizontal into google translate and found many (some surprising, indonesian!?!) languages where H and V would directly apply.

In either case, I have no issues with leaving behavior as it currently stand. Even if a user wants to rotate a sketch or skew to a 3d perspective, it is a very poor practice (my opinion) to try and sketch from such a perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features UI/UX WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

5 participants