Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a confirmation modal when closing create/edit segment with changes #3979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Add a confirmation modal when closing create/edit segment with changes #3979

wants to merge 1 commit into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 17, 2024 •
edited

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adds a confirmation modal when segment details are entered and user attempts to close the modal

How did you test this code?

  • Create / edit a segment, editing name, description or any rules
  • Attempt to close the modal

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:50pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:50pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:50pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 17, 2024
@kyle-ssg kyle-ssg linked an issue May 17, 2024 that may be closed by this pull request
No confirmation to discard unsaved segment or feature creation modals #3921
Open
@kyle-ssg kyle-ssg requested a review from rolodato May 17, 2024 13:40
@kyle-ssg kyle-ssg changed the title chore: Add a confirmation modal when closing create/edit segment with unsave… chore: Add a confirmation modal when closing create/edit segment with changes May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

Uffizzi Ephemeral Environment deployment-51903

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3979

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No confirmation to discard unsaved segment or feature creation modals
2 participants
@kyle-ssg @novakzaballa