Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): set input and switch types to none if not configured #5026

Merged
merged 1 commit into from
May 24, 2024

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented May 17, 2024

Fixes #5018

Summary of changes:

  • set all inputs and switches to None prior to parsing radio.yml
  • remove loading default hardware definitions from within general settings init as not always wanted
  • remove loading default hardware definitions before parsing switch settings as performed in general settings
  • move needs conversion test to after final parse step (housekeeping)

@elecpower elecpower added companion Related to the companion software bug/regression ↩️ A new version of EdgeTX broke something labels May 17, 2024
@elecpower elecpower added this to the 2.10.1 milestone May 17, 2024
@pfeerick pfeerick changed the title fix(cpn): set input and switch types to none if not parsed from radio yaml fix(cpn): set input and switch types to none if not configured May 24, 2024
@pfeerick pfeerick merged commit fae3f83 into main May 24, 2024
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-5018 branch May 24, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion - Pots Settings not saving
2 participants