Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Companion - Pots Settings not saving #5018

Closed
1 task done
TheIsotopes opened this issue May 16, 2024 · 1 comment · Fixed by #5026
Closed
1 task done

Companion - Pots Settings not saving #5018

TheIsotopes opened this issue May 16, 2024 · 1 comment · Fixed by #5026
Assignees
@elecpower
Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software

Comments

@TheIsotopes
Copy link
Contributor

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

With the current release, the pots settings are not saved in the Companion.

Expected Behavior

save settings correctly

Steps To Reproduce

  • load Settings from PC
  • Edit Radio Settings / Hardware
  • set Pots S1/S2 to None
  • save Settings
  • close Companion
  • open again Companion
  • load Settings from PC
  • back to Edit Radio Settings / Hardware
  • you will see the Pots enabled again

Version

2.10.0

Transmitter

RadioMaster Zorro

Operating System (OS)

Windows

OS Version

11 23H2

Anything else?

No response
@TheIsotopes TheIsotopes added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels May 16, 2024
@TheIsotopes TheIsotopes changed the title Companion - Pots not saving Companion - Pots Settings not saving May 16, 2024
@pfeerick pfeerick added the companion Related to the companion software label May 16, 2024
@elecpower elecpower mentioned this issue May 17, 2024
Merged
@elecpower elecpower added bug/regression ↩️ A new version of EdgeTX broke something and removed bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels May 17, 2024
@elecpower elecpower self-assigned this May 17, 2024
@elecpower
Copy link
Collaborator

elecpower commented May 17, 2024 •
edited

When a pot, slider or switch is set to None it is not written to the radio settings yml file.
When the file is read, the hardware definition default value is used if not found.
In all cases, should set to None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elecpower elecpower

Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cpn): set input and switch types to none if not configured EdgeTX/edgetx
3 participants
@pfeerick @elecpower @TheIsotopes