-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistyped parameter in method update of Decipher class #68693
Comments
Please can an moderator delete this.... |
Here are the responses about this parameter: #59476 |
Thanks for you answer. I don't understand, since it would be an unique signature even without the inputEncoding parameter with a Buffer, why can't we just remove this parameter if it is ignored ? Is it a retro-compatibility issue ? In which case we could mark it as deprecated. |
According to @SimonSchick's reply, the second parameter is ignored and the user should not pass it 😀. |
That doesn't answer the "why" can't we remove this parameter if it is ignored anyway ^^ |
See https://nodejs.org/api/crypto.html#decipherupdatedata-inputencoding-outputencoding according to the docs Please provide your use case or example of why this should not be the case. |
Hi there, I think the type defined here for the parameter
inputEncoding
with the signature method using a Buffer is wrong and should support Encoding too.DefinitelyTyped/types/node/crypto.d.ts
Line 1189 in 7bd4a02
Imo,
inputEncoding
property should have the same types as in this signature :DefinitelyTyped/types/node/crypto.d.ts
Line 1190 in 7bd4a02
Best regards,
Paul.
The text was updated successfully, but these errors were encountered: