Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated ical series not accounting for public and univiersity holidays #344

Open
MoralCode opened this issue Jan 11, 2024 · 3 comments
Open
Labels

Comments

@MoralCode
Copy link
Contributor

Thanks for the work done closing #63 in #343, I just tried out the new changes and it looks like it largely works!

I did notice that, because the first week of class starts with MLK day, it is causing all of my MWF classes to not generate until the next week
Screenshot_20240111_113526

Screenshot_20240111_113713

Additionally, it seems to be generating events through RIT's Spring break
Screenshot_20240111_113555

since RIT's institute calendar also includes the public holidays that we have no class, this may be relatively easy to implement:

  1. scrape, or get ITS to add an iCal version of the data from https://www.rit.edu/calendar
  2. add some code to filter days off out from other institute events things (such as the last day of the add/drop period) and convert to DateTime format
  3. follow the linked specs to include them as exception dates in each VEVENT declaration https://icalendar.org/iCalendar-RFC-5545/3-8-5-1-exception-date-times.html (thanks @natep-tech for the link)

Unless RIT can maintain the list of days off (which IMO it should) this may add some extra maintenance burden to CSH. However some of the open source groups at RIT may also be able to help take this on as well in the meantime.

@MoralCode
Copy link
Contributor Author

I have filed a ticket with the helpdesk to see if they will add an .ics calendar of university days off to the rit.edu/calendar webpage to make this easier

@MoralCode
Copy link
Contributor Author

It also looks like it might not be too hard to throw together some PHP to scrape the future days calendar table from https://www.rit.edu/calendar/future-chart into some kind of url scheme like <domain>/universitycalendar/[spring/fall]/[year]/[informational/holidays].ics

i might play with making some PHP script for this on my RIT userspace

@MoralCode
Copy link
Contributor Author

I played with this a bit, it seems possible, but its a fair bit of date parsing drudgery.

I dont have time to build this before knowing that it will be useful, so if this is an API that the team wants, you need to let me know otherwise I will assume you've got it covered or dont need it. Happy to share my source code so far if anyone's interested as well, just lmk

@esoccoli esoccoli added the bug label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants