Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support GitInfo in LastModified #985

Closed
delize opened this issue Mar 23, 2024 · 4 comments
Closed

Feature Request: Support GitInfo in LastModified #985

delize opened this issue Mar 23, 2024 · 4 comments

Comments

@delize
Copy link
Contributor

delize commented Mar 23, 2024

What happened?

Currently, Hugo supports last modified timestamps for Blog Posts using Git: https://gohugo.io/methods/page/gitinfo/

However, it doesn't seem like this is natively supported in the Stack theme. When enabled or added to: https://github.com/CaiJimmy/hugo-theme-stack-starter/blob/master/config/_default/config.toml

Using: https://gohugo.io/getting-started/configuration/#configure-dates

This appears to cause issues when creating new blog posts or modifications due to the syntax being used across the blog theme.

It would be nice if this was fully supported - so that people wouldn't have to rely on manually inputting last modified dates.

Hugo version

0.120

Theme version

3.24.2

What browsers are you seeing the problem on?

No response

More information about the browser

No response

Relevant log output

No response

Link to Minimal Reproducible Example

https://github.com/CaiJimmy/hugo-theme-stack-starter

@sailingsky

This comment was marked as duplicate.

@delize
Copy link
Contributor Author

delize commented Mar 23, 2024

@sailingsky this could be a different problem. See the pinned issue.
#974

This issue is more for architectural changes to incorporate last modified, determine how syntax should appear and where when gitinfo is enabled, etc.

One can of course enable Gitinfo, but, there were all sorts of issues getting it to work / format cleanly without altering mass amounts of code.

@sailingsky
Copy link

@sailingsky this could be a different problem. See the pinned issue. #974

This issue is more for architectural changes to incorporate last modified, determine how syntax should appear and where when gitinfo is enabled, etc.

One can of course enable Gitinfo, but, there were all sorts of issues getting it to work / format cleanly without altering mass amounts of code.

thx, I fixed it.

@CaiJimmy
Copy link
Owner

I have tested the starter template locally with enableGitInfo = true enabled and it seems to work fine. It seems to be related to the CI configuration of the starter template. I believe this issue can be resolved by CaiJimmy/hugo-theme-stack-starter#39

I'm going to close this issue and merge this pull request. Feel free to reopen it if this solution does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants