Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies file with tag files and the resulting doxygen "dxy" file #8211

Closed
albert-github opened this issue May 17, 2024 · 3 comments · Fixed by #8248
Closed

Dependencies file with tag files and the resulting doxygen "dxy" file #8211

albert-github opened this issue May 17, 2024 · 3 comments · Fixed by #8248

Comments

@albert-github
Copy link
Contributor

With the fix b9ee8c6 a fix (by @sloriot) was made to fix the issue:

error: Tag file '.../doc_tags/Lab.tag' does not exist or is not a file. Skipping it...

when building the documentation of the (not really supported) Three package.
The fix as is is correct and worked for a clean build, but when using an existing build it didn't work as the Three.dxy configuration file was not rebuild and a remake of the cmake files was not triggered.
The change was made in the file Three/doc/Tree/dependencies and this is not listed as a dependency to regenerate the Three.dxy

In an email discussion it was pointed out by @lrineau that:

The answer is probably https://cmake.org/cmake/help/latest/prop_dir/CMAKE_CONFIGURE_DEPENDS.html

The solution lies probably in Documentation/doc/CMakeLists.txt where a configuration dependency between:
${depend}/doc/${depend}/dependencies and ${CGAL_DOC_DXY_DIR}/${depend}.dxy has to be created, where depend is a package name).

@lrineau lrineau added this to the 6.0 milestone May 17, 2024
@lrineau lrineau self-assigned this May 17, 2024
@lrineau lrineau modified the milestones: 6.0, 6.1-beta May 28, 2024
@lrineau
Copy link
Member

lrineau commented Jun 7, 2024

I was bitten by that bug, and it made me loss minutes of work. So I fixed it in the unrelated PR #8248 (commit 50d7aba).

@lrineau lrineau linked a pull request Jun 7, 2024 that will close this issue
@lrineau lrineau modified the milestones: 6.1-beta, 6.0-beta Jun 12, 2024
@lrineau
Copy link
Member

lrineau commented Jun 12, 2024

I was bitten by that bug, and it made me loss minutes of work. So I fixed it in the unrelated PR #8248 (commit 50d7aba).

Should be fixed in CGAL master, now. @albert-github, do you confirm the bug is fixed?

@albert-github
Copy link
Contributor Author

albert-github commented Jun 12, 2024

I did a quick test.

  • build the documentation
  • change the dependencies and build the documentation
    • CMake was automatically rerun
    • the new dependencies were present
  • undo the change in the dependencies and build the documentation
    • CMake was automatically rerun
    • the old dependencies were present

This confirms to me that this problem is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants