Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the regeneration of Installation/include/CGAL/license/ #8191

Open
lrineau opened this issue May 6, 2024 · 0 comments
Open

Issue with the regeneration of Installation/include/CGAL/license/ #8191

lrineau opened this issue May 6, 2024 · 0 comments

Comments

@lrineau
Copy link
Member

lrineau commented May 6, 2024

Issue Details

In Installation/include/CGAL/license/README.md, one can read:

To generate the `PACKAGE.h` files, from the file `gpl_package_list.txt`:
cmake -P generate_files.cmake

I tried that to create a new license header file for a new package (see #8186) and the result, starting from a clean workdir of cgal/master, was a big diff, see https://gist.github.com/lrineau/5271666984da974d23daabcee09e63a7

There are parts of the diff that show that the script generate_files.cmake is actually wrong:

part 1:

index 854b366ba54..ebd2bf82ac4 100644
--- a/Installation/include/CGAL/license/Polygon_mesh_processing/locate.h
+++ b/Installation/include/CGAL/license/Polygon_mesh_processing/locate.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2019  GeometryFactory SARL (France).
+// Copyright (c) 2016  GeometryFactory SARL (France).
 // All rights reserved.
 //
 // This file is part of CGAL (www.cgal.org)

part 2:

@@ -33,8 +29,8 @@
 
 #    ifdef CGAL_LICENSE_ERROR
 #      error "Your commercial license for CGAL does not cover this release \
-of the Polygonal Surface Reconstruction package. \
-You get this error, as you defined CGAL_LICENSE_ERROR."
+              of the Polygonal Surface Reconstruction package. \
+              You get this error, as you defined CGAL_LICENSE_ERROR."
 #    endif // CGAL_LICENSE_ERROR
 
 #  endif // CGAL_POLYGONAL_SURFACE_RECONSTRUCTION_COMMERCIAL_LICENSE < CGAL_RELEASE_DATE
  1. The copyright year should not be hard-coded to 2016.
  2. The "red" version is right, otherwise the error message triggered by #error contains spurious sequences of spaces.
@lrineau lrineau added this to the 6.0-beta milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant