-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL 8.0 support #7114
Comments
I am part of the Cloudron team. We would be appy to submit PRs/patches to make AzuraCast work with MySQL. Please let us know if this is of interest, thanks! |
If you understand how useful Cloudron is to make Azuracast deployment easy, you would want to help here. Please make it happen. |
@vladimirdulov @gramakri Thank you all for your work in getting AzuraCast to work on Cloudron! It shouldn't be a terribly difficult thing to get running with the exception of the database issues we're having here. I'm happy to remove the auto-version detection (in fact, we can set that so it only happens on localhost connections, so unmodified Docker installs still get the perf boost but custom ones are supported). As for removing the We may have to think of a way to specify that we want those specifiers for MariaDB-based DBs but can remove them for MySQL ones (with the understanding that, without them, some migrations may be less robust for failing midway through and re-running). |
@vladimirdulov @gramakri Upon second examination, it appears the only time we've used the That should put us at full compliance with MySQL 8.0. I'll leave this issue open in case there are any other issues discovered, but the latest Rolling Release version (which is currently deploying) should be working. |
@BusterNeece I've just noticed a typo in #7114 A new PR has been created to fix it |
@vladimirdulov Should be fixed now. |
Thank you, seems to work well now. |
Installation Method
Docker Installation
AzuraCast Release Channel
Stable Channel
Current AzuraCast Version
0.19.7
What happened?
Hello,
I'm packaging AzuraCast application for Cloudron.io. Technically I've managed to build and get AzuraCast v0.19.7 app working successfully.
Cloudron is based on docker and has MySQL 8.0 support out of the box (but no MariaDB support at the moment) so there are differences and difficulties to make it working in the long term.
I'd like to propose some suggestions/changes to AzuraCast upstream so it could work with MySQL 8.0.
IF NOT EXISTS/IF EXISTS
clauses forCOLUMN, INDEX, KEY
from respective queries which not supported by MySQL server.Basically I patched them as following:
then commented the query out
AzuraCast/src/Entity/Migration/Version20201003021913.php
Line 22 in adef71b
./config/services.php
https://github.com/AzuraCast/AzuraCast/blob/0.19.7/config/services.php#L81
Namely I need to remove
ONLY_FULL_GROUP_BY
option fromsql-mode
.This is a workaround for errors like:
serverVersion
in the connection options in./config/services.php
https://github.com/AzuraCast/AzuraCast/blob/0.19.7/config/services.php#L84
Basically I commented it out so Doctrine could guess the database server version automatically.
Considering that Cloudron community is happy to see AzuraApp app being published in Cloudron App Store for one-click installation, we'd like to see MySQL 8.0 support in the upstream.
Obviously the app update should be robust in the long term and those cannot be kept as patches.
Relevant log output
No response
The text was updated successfully, but these errors were encountered: