Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor shifts away from textbox #426

Closed
Landorlin opened this issue Nov 18, 2023 · 7 comments
Closed

cursor shifts away from textbox #426

Landorlin opened this issue Nov 18, 2023 · 7 comments
Milestone

Comments

@Landorlin
Copy link

Using the 8vim cursor (by accident or to ensure a none space ending) sometimes gets me out of the textbox leading to unwanted behavior like eg sending sms.

To Reproduce
Steps to reproduce the behavior:

  1. Open a sms-messenger (i tried the one from simplemobile.com and a preinstalled from samsung)
  2. Write a message and use the cursor. It is now possible to move to the send button sending the message using space.

Expected behavior
The cursor should stay inside it's textbox.

Smartphone (please complete the following information):

  • Device: Samsung Xcover 5
  • OS: Android 13

Additional context
maybe this is considered not a bug but a feature. In this case there should be an on/off toggle for it.

@MaethorNaur
Copy link
Contributor

MaethorNaur commented Nov 18, 2023

Hi, could you record the behaviour so I can understand the pattern correctly? I've tried what you described on my Samsung tablet and the built-in SMS messenger but couldn't replicate it.
Also if you swipe from the centre to the right it moves to the send button (as expected). Not sure if that what happened.

@Aiz0
Copy link

Aiz0 commented Nov 20, 2023

I don't think the regular cursor movement should be able to move focus outside the textbox, especially since the cursor moves so fast.
There are cases where it's useful but most of the times I do it by accident.
Might be better implemented as another type of movement.

If you change the cursor movement behavior to move word by word you can no longer leave the textbox, but you also can't use it to check for extra spaces at the end since the cursor refuses to move there, this is also unexpected behavior.

Tested on version 16.2

@Landorlin
Copy link
Author

YouCut_20231120_105638589.mp4

i just think the cursor should stay inside its textbox as default like in all other editors :)

@Redo11
Copy link

Redo11 commented May 11, 2024

Problem here is because the code uses KEYCODE_DPAD_* (like in a controller, where it would be expected) instead of MOVE_CURRENT_END_POINT_* (what most keyboard behavior is like). Should be easy to change. @flide please fix

@flide
Copy link
Collaborator

flide commented May 11, 2024

I agree

@MaethorNaur MaethorNaur added this to the v0.17.0 milestone May 12, 2024
MaethorNaur added a commit to MaethorNaur/8VIM that referenced this issue May 12, 2024
Cursor movements was moving the cursor out of the input box

refs: 8VIM#426
@MaethorNaur
Copy link
Contributor

MaethorNaur commented May 12, 2024

@Redo11 A fix is available from #509. You can download the debug version from the private F-droid repo (https://github.com/8VIM/fdroid)

P.S.: you can install those versions along the stable one they won't

@Redo11
Copy link

Redo11 commented May 22, 2024

thanks

MaethorNaur added a commit that referenced this issue Jun 1, 2024
)

Cursor movements was moving the cursor out of the input box

refs: #426
@flide flide closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants